Skip to content

[mlir] Silence -Wdangling-assignment-gsl in OperationSupport.h #126140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[mlir] Silence -Wdangling-assignment-gsl in OperationSupport.h #126140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions mlir/include/mlir/IR/OperationSupport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,13 +997,21 @@ struct OperationState {
if (!properties) {
T *p = new T{};
properties = p;
#if defined(__clang__) && __has_warning("-Wdangling-assignment-gsl")
#pragma clang diagnostic push
// https://github.com/llvm/llvm-project/issues/126600
#pragma clang diagnostic ignored "-Wdangling-assignment-gsl"
#endif
propertiesDeleter = [](OpaqueProperties prop) {
delete prop.as<const T *>();
};
propertiesSetter = [](OpaqueProperties new_prop,
propertiesSetter = [](OpaqueProperties newProp,
const OpaqueProperties prop) {
*new_prop.as<T *>() = *prop.as<const T *>();
*newProp.as<T *>() = *prop.as<const T *>();
};
#if defined(__clang__) && __has_warning("-Wdangling-assignment-gsl")
#pragma clang diagnostic pop
#endif
propertiesId = TypeID::get<T>();
}
assert(propertiesId == TypeID::get<T>() && "Inconsistent properties");
Expand Down