[clang-tidy] Replace /* ... */ single-line comments with // ... comments #124319

4m4n-x-B4w4ne · 2025-01-24T18:01:48Z

Fixes: #24841.
I have also cherry-picked commit a3c7fca.
@LegalizeAdulthood @PiotrZSL

…20087)" This reverts commit 5bec2b7. reverting previous commits on this branch

llvmbot · 2025-01-24T18:02:23Z

@llvm/pr-subscribers-clang-tidy

@llvm/pr-subscribers-clang-tools-extra

Author: None (4m4n-x-B4w4ne)

Changes

This Pull Request is to fix issue #24841.
I am also cherry-pick commit a3c7fca.
@LegalizeAdulthood @PiotrZSL

Full diff: https://github.com/llvm/llvm-project/pull/124319.diff

7 Files Affected:

(modified) clang-tools-extra/clang-tidy/modernize/CMakeLists.txt (+1)
(modified) clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp (+3)
(added) clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp (+126)
(added) clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.h (+40)
(modified) clang-tools-extra/docs/ReleaseNotes.rst (+5)
(added) clang-tools-extra/docs/clang-tidy/checks/modernize/use-cpp-style-comments.rst (+38)
(added) clang-tools-extra/test/clang-tidy/checkers/modernize/use-cpp-style-comments.cpp (+68)

diff --git a/clang-tools-extra/clang-tidy/modernize/CMakeLists.txt b/clang-tools-extra/clang-tidy/modernize/CMakeLists.txt
index bab1167fb15ff2..f07dd5efecc58e 100644
--- a/clang-tools-extra/clang-tidy/modernize/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/modernize/CMakeLists.txt
@@ -31,6 +31,7 @@ add_clang_library(clangTidyModernizeModule STATIC
   UseAutoCheck.cpp
   UseBoolLiteralsCheck.cpp
   UseConstraintsCheck.cpp
+  UseCppStyleCommentsCheck.cpp
   UseDefaultMemberInitCheck.cpp
   UseDesignatedInitializersCheck.cpp
   UseEmplaceCheck.cpp
diff --git a/clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp b/clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp
index fc46c72982fdce..1917d562f7ce8d 100644
--- a/clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp
@@ -32,6 +32,7 @@
 #include "UseAutoCheck.h"
 #include "UseBoolLiteralsCheck.h"
 #include "UseConstraintsCheck.h"
+#include "UseCppStyleCommentsCheck.h"
 #include "UseDefaultMemberInitCheck.h"
 #include "UseDesignatedInitializersCheck.h"
 #include "UseEmplaceCheck.h"
@@ -107,6 +108,8 @@ class ModernizeModule : public ClangTidyModule {
         "modernize-use-bool-literals");
     CheckFactories.registerCheck<UseConstraintsCheck>(
         "modernize-use-constraints");
+    CheckFactories.registerCheck<UseCppStyleCommentsCheck>(
+        "modernize-use-cpp-style-comments");
     CheckFactories.registerCheck<UseDefaultMemberInitCheck>(
         "modernize-use-default-member-init");
     CheckFactories.registerCheck<UseEmplaceCheck>("modernize-use-emplace");
diff --git a/clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp
new file mode 100644
index 00000000000000..3c25c50bab759c
--- /dev/null
+++ b/clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp
@@ -0,0 +1,126 @@
+//===--- UseCppStyleCommentsCheck.cpp - clang-tidy-------------------------===//
+
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "UseCppStyleCommentsCheck.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/Lex/Lexer.h"
+#include "clang/Lex/Preprocessor.h"
+#include <iostream>
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::modernize {
+class UseCppStyleCommentsCheck::CStyleCommentHandler : public CommentHandler {
+public:
+  CStyleCommentHandler(UseCppStyleCommentsCheck &Check)
+      : Check(Check),
+        CStyleCommentMatch(
+                          "^[ \t]*/\\*+[ \t\r\n]*(.*[ \t\r\n]*)*[ \t\r\n]*\\*+/[ \t\r\n]*$"){}
+
+  std::string convertToCppStyleComment(const SourceManager &SM, const SourceRange &Range) {
+    StringRef CommentText = Lexer::getSourceText(
+        CharSourceRange::getTokenRange(Range), SM, LangOptions());
+
+    std::string InnerText = CommentText.str();
+    InnerText.erase(0, 2);
+    InnerText.erase(InnerText.size() - 2, 2);
+
+    std::string Result;
+    std::istringstream Stream(InnerText);
+    std::string Line;
+
+    if (std::getline(Stream, Line)) {
+      size_t startPos = Line.find_first_not_of(" \t");
+      if (startPos != std::string::npos) {
+          Line = Line.substr(startPos);
+      } else {
+          Line.clear();
+      }
+      Result += "// " + Line;
+    }
+
+    while (std::getline(Stream, Line)) {
+    size_t startPos = Line.find_first_not_of(" \t");
+      if (startPos != std::string::npos) {
+          Line = Line.substr(startPos);
+      } else {
+          Line.clear();
+      }
+      Result += "\n// " + Line;
+    }
+    return Result;
+  }
+
+  bool HandleComment(Preprocessor &PP, SourceRange Range) override {
+    const SourceManager &SM = PP.getSourceManager();
+
+    if (Range.getBegin().isMacroID() ||
+        SM.isInSystemHeader(Range.getBegin())) {
+        return false;
+    }
+
+    const StringRef Text =
+        Lexer::getSourceText(CharSourceRange::getCharRange(Range),
+                             SM, PP.getLangOpts());
+
+    SmallVector<StringRef> Matches;
+    if (!CStyleCommentMatch.match(Text, &Matches)) {
+        return false;
+    }
+
+    SourceLocation CommentStart = Range.getBegin();
+    SourceLocation CommentEnd = Range.getEnd();
+
+    unsigned StartLine = SM.getSpellingLineNumber(CommentStart);
+    unsigned EndLine = SM.getSpellingLineNumber(CommentEnd);
+
+   
+    if (StartLine == EndLine) {
+      SourceLocation LineBegin = SM.translateLineCol(
+          SM.getFileID(CommentStart), StartLine, 1);
+      SourceLocation LineEnd = SM.translateLineCol(SM.getFileID(CommentEnd), EndLine, std::numeric_limits<unsigned>::max());
+      StringRef LineContent =
+          Lexer::getSourceText(CharSourceRange::getCharRange(LineBegin, LineEnd),
+                              SM, PP.getLangOpts());
+      size_t CommentStartOffset = SM.getSpellingColumnNumber(CommentStart) - 1;
+      StringRef AfterComment = LineContent.drop_front(CommentStartOffset + Text.size());
+
+      if (!AfterComment.trim().empty()) {
+          return false;
+      }
+    }
+    
+    Check.diag(
+        Range.getBegin(),
+        "use C++ style comments '//' instead of C style comments '/*...*/'")
+        << clang::FixItHint::CreateReplacement(
+               Range, convertToCppStyleComment(SM, Range));
+
+    return false;
+}
+
+
+private:
+  UseCppStyleCommentsCheck &Check;
+  llvm::Regex CStyleCommentMatch;
+};
+
+UseCppStyleCommentsCheck::UseCppStyleCommentsCheck(StringRef Name,
+                                                   ClangTidyContext *Context)
+    : ClangTidyCheck(Name, Context),
+      Handler(std::make_unique<CStyleCommentHandler>(*this)) {}
+
+void UseCppStyleCommentsCheck::registerPPCallbacks(
+    const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP) {
+  PP->addCommentHandler(Handler.get());
+}
+
+void UseCppStyleCommentsCheck::check(const MatchFinder::MatchResult &Result) {}
+
+UseCppStyleCommentsCheck::~UseCppStyleCommentsCheck() = default;
+} // namespace clang::tidy::modernize
diff --git a/clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.h b/clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.h
new file mode 100644
index 00000000000000..3d604683de5a24
--- /dev/null
+++ b/clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.h
@@ -0,0 +1,40 @@
+//===--- UseCppStyleCommentsCheck.h - clang-tidy---------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MODERNIZE_USE_CPP_STYLE_COMMENTS_CHECK_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MODERNIZE_USE_CPP_STYLE_COMMENTS_CHECK_H
+
+#include "../ClangTidyCheck.h"
+#include <sstream>
+namespace clang::tidy::modernize {
+/// Detects C Style comments and suggests to use C++ style comments instead.
+///
+/// For the user-facing documentation see:
+/// http://clang.llvm.org/extra/clang-tidy/checks/modernize/use-cpp-style-comments.html
+class UseCppStyleCommentsCheck : public ClangTidyCheck {
+public:
+  UseCppStyleCommentsCheck(StringRef Name, ClangTidyContext *Context);
+
+  ~UseCppStyleCommentsCheck() override;
+
+  bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
+    return LangOpts.CPlusPlus;
+  }
+
+  void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP,
+                           Preprocessor *ModuleExpanderPP) override;
+
+  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+
+private:
+  class CStyleCommentHandler;
+  std::unique_ptr<CStyleCommentHandler> Handler;
+};
+} // namespace clang::tidy::modernize
+
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MODERNIZE_USE_CPP_STYLE_COMMENTS_CHECK_H
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index cc5f64a3f9fa32..a89cd1a8b80e50 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -173,6 +173,11 @@ New checks
 
   Replace comparisons between signed and unsigned integers with their safe
   C++20 ``std::cmp_*`` alternative, if available.
+  
+- New :doc:`modernize-use-cpp-style-comments
+  <clang-tidy/checks/modernize/use-cpp-style-comments>` check.
+
+  Detects C Style comments and suggests to use C++ style comments instead.
 
 - New :doc:`portability-template-virtual-member-function
   <clang-tidy/checks/portability/template-virtual-member-function>` check.
diff --git a/clang-tools-extra/docs/clang-tidy/checks/modernize/use-cpp-style-comments.rst b/clang-tools-extra/docs/clang-tidy/checks/modernize/use-cpp-style-comments.rst
new file mode 100644
index 00000000000000..5eaf759a3db6d6
--- /dev/null
+++ b/clang-tools-extra/docs/clang-tidy/checks/modernize/use-cpp-style-comments.rst
@@ -0,0 +1,38 @@
+.. title:: clang-tidy - use-cpp-style-comments
+
+modernize-use-cpp-style-comments
+=======================
+
+Replace C-style comments with C++-style comments.
+C-style comments (`/* ... */`) are inherited from C, while C++ introduces 
+`//` as a more concise, readable, and less error-prone alternative. Modern C++ 
+guidelines recommend using C++-style comments for consistency and 
+maintainability. This check identifies and replaces C-style comments with 
+equivalent C++-style comments.
+
+Examples:
+
+Input:
+.. code-block::c++
+    /* This is a single-line comment */
+    int x = 42;  /* Inline comment */
+
+    /* This is a
+    multi-line comment */
+
+
+Output:
+.. code-block::c++
+    // This is a single-line comment
+    int x = 42;  // Inline comment
+
+    // This is a
+    // multi-line comment
+
+.. note::
+
+    Inline Comments are neither fixed nor warned.
+    Example:
+    .. code-block:: c++
+        int a = /* this is a comment */ 5;
+
diff --git a/clang-tools-extra/test/clang-tidy/checkers/modernize/use-cpp-style-comments.cpp b/clang-tools-extra/test/clang-tidy/checkers/modernize/use-cpp-style-comments.cpp
new file mode 100644
index 00000000000000..f56750591e035f
--- /dev/null
+++ b/clang-tools-extra/test/clang-tidy/checkers/modernize/use-cpp-style-comments.cpp
@@ -0,0 +1,68 @@
+// RUN: %check_clang_tidy -std=c++11 %s modernize-use-cpp-style-comments %t -- --
+
+// Single-line full C-style comment
+static const int CONSTANT = 42; /* Important constant value */
+// CHECK-MESSAGES: :[[@LINE-1]]:33: warning: use C++ style comments '//' instead of C style comments '/*...*/' [modernize-use-cpp-style-comments]
+// CHECK-FIXES: static const int CONSTANT = 42; // Important constant value
+
+// Inline comment that should NOT be transformed
+int a = /* inline comment */ 5;
+
+// Multiline full-line comment
+/* This is a multiline comment
+   that spans several lines
+   and should be converted to C++ style */
+// CHECK-MESSAGES: :[[@LINE-3]]:1: warning: use C++ style comments '//' instead of C style comments '/*...*/' [modernize-use-cpp-style-comments]
+// CHECK-FIXES: // This is a multiline comment
+// CHECK-FIXES: // that spans several lines
+// CHECK-FIXES: // and should be converted to C++ style
+void fnWithSomeBools(bool A,bool B) {}
+// Function with parameter inline comments
+void processData(int data /* input data */, 
+                 bool validate /* perform validation */) {
+    // These inline comments should NOT be transformed
+    fnWithSomeBools(/*ControlsA=*/ true, /*ControlsB=*/ false);
+}
+
+// Multiline comment with asterisk styling
+/*******************************
+ * Block comment with asterisks
+ * Should be converted to C++ style
+ *******************************/
+// CHECK-MESSAGES: :[[@LINE-4]]:1: warning: use C++ style comments '//' instead of C style comments '/*...*/' [modernize-use-cpp-style-comments]
+// CHECK-FIXES: // ******************************
+// CHECK-FIXES: // * Block comment with asterisks
+// CHECK-FIXES: // * Should be converted to C++ style
+// CHECK-FIXES: // ******************************
+int calculateSomething() { return 1;}
+// Comment at end of complex line
+int complexCalculation = calculateSomething(); /* Result of complex calculation */
+// CHECK-MESSAGES: :[[@LINE-1]]:48: warning: use C++ style comments '//' instead of C style comments '/*...*/' [modernize-use-cpp-style-comments]
+// CHECK-FIXES: int complexCalculation = calculateSomething(); // Result of complex calculation
+
+// Nested comments and edge cases
+void edgeCaseFunction() {
+    int x = 10 /* First value */ + 20 /* Second value */;  // Inline comments should not transform
+    
+    /* Comment with special characters !@#$%^&*()_+ */
+    // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: use C++ style comments '//' instead of C style comments '/*...*/' [modernize-use-cpp-style-comments]
+    // CHECK-FIXES: // Comment with special characters !@#$%^&*()_+
+}
+
+// Multiline comment with various indentations
+    /* This comment is indented
+       and should preserve indentation when converted */
+// CHECK-MESSAGES: :[[@LINE-2]]:5: warning: use C++ style comments '//' instead of C style comments '/*...*/' [modernize-use-cpp-style-comments]
+// CHECK-FIXES:     // This comment is indented
+// CHECK-FIXES:     // and should preserve indentation when converted
+
+// Complex function with mixed comment types
+void complexFunction() {
+    /* Full line comment at start of block */
+    // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: use C++ style comments '//' instead of C style comments '/*...*/' [modernize-use-cpp-style-comments]
+    // CHECK-FIXES: // Full line comment at start of block
+    
+    int x = 10; /* Inline comment not to be transformed */
+    // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: use C++ style comments '//' instead of C style comments '/*...*/' [modernize-use-cpp-style-comments]
+    // CHECK-FIXES: int x = 10; // Inline comment not to be transformed
+}
\ No newline at end of file

github-actions · 2025-01-24T18:06:26Z

✅ With the latest revision this PR passed the C/C++ code formatter.

vbvictor · 2025-01-24T19:06:36Z

Thank you for working on this check!
Please, read comments on previous pull request #99713.
I think there could be some improvements done based on comments in that PR.
For moving this check to readability section script clang-tools-extra/clang-tidy/rename_check.py can be useful.

clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp

clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.h

clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp

HerrCai0907 · 2025-01-25T12:56:59Z

clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp

+      }
+    }
+
+    Check.diag(


could you add test like

/* aaa bbbb ccc */ int a = 1;

It may not be processed correctly.

Sorry to ask, but the thing is, how shall I handle this kind of case? The way this code is written looks like a bad Coding practice. Also, If I want to correct it, what will the correct comment-code order be? l

I think ignoring this type of comments will be the best option, so I am working on it.

@HerrCai0907 I have done this thing. Can you please verify this?

clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp

clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.h

clang-tools-extra/docs/clang-tidy/checks/modernize/use-cpp-style-comments.rst

clang-tools-extra/test/clang-tidy/checkers/modernize/use-cpp-style-comments.cpp

clang-tools-extra/docs/clang-tidy/checks/modernize/use-cpp-style-comments.rst

clang-tools-extra/docs/ReleaseNotes.rst

4m4n-x-B4w4ne · 2025-01-27T16:58:55Z

Can anyone please help me? Why is Test Documentation build is failing? I am in no clue.

…k.cpp

vbvictor · 2025-01-27T17:13:03Z

Can anyone please help me? Why is Test Documentation build is failing? I am in no clue.

Restore clang-tools-extra/clang-tidy/modernize/CMakeLists.txt and clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp as they were before (with no changes to them).
As for now it fails to find "UseCppStyleCommentsCheck.h" and "UseCppStyleCommentsCheck.cpp" I guess.

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.cpp

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.h

clang-tools-extra/docs/ReleaseNotes.rst

clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-style-comments.rst

PiotrZSL

code formatting (looks sometimes strange)
check performance (avoid creating new strings, copies)
few nits

PiotrZSL · 2025-02-10T21:00:01Z

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.cpp

+    InnerText.erase(InnerText.size() - 2, 2);
+
+    std::string Result;
+    std::istringstream Stream(InnerText);


avoid using istringstream , thats heavy to construct due to locales, just split string by '\n or \r'

Done Thanks! Can you please Review it?

PiotrZSL · 2025-02-10T21:01:16Z

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.cpp

+      if (StartPos != std::string::npos) {
+        Line = Line.substr(StartPos);
+      } else {
+        Line.clear();


avoid text copy, instead of generate list of "ranges to be replaced" and then generate FixIt for every of them

Done Thanks! Can you please Review it?

PiotrZSL · 2025-02-10T21:02:29Z

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.cpp

+    const SourceLocation LineBegin =
+        SM.translateLineCol(SM.getFileID(CommentEnd), EndLine, EndCol);
+    const SourceLocation LineEnd =
+        SM.translateLineCol(SM.getFileID(CommentEnd), EndLine,
+                            std::numeric_limits<unsigned>::max());
+    const StringRef AfterComment =
+        Lexer::getSourceText(CharSourceRange::getCharRange(LineBegin, LineEnd),
+                             SM, PP.getLangOpts());


maybe better work on offsets instead of lines/collumns, you could just get next token after comment and check if there is new line character between them.

Done Thanks! Can you please Review it?

PiotrZSL · 2025-02-10T21:03:50Z

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.cpp

+    }
+
+    SmallVector<StringRef> Matches;
+    if (!CStyleCommentMatch.match(Text, &Matches)) {


add also custom regexp as configuration option and called it ExcludedComents or something, in such case if this match comment, then exclude.

Done Thanks! Can you please Review it?

@PiotrZSL Can you please review it? like and tell me what next to be done.

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.cpp

clang-tools-extra/test/clang-tidy/checkers/readability/use-cpp-style-comments.cpp

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.h

clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-style-comments.rst

4m4n-x-B4w4ne · 2025-03-06T11:05:28Z

@EugeneZelenko @vbvictor @PiotrZSL @HerrCai0907 Can anyone please guide me further?

HerrCai0907

LGTM with nit.

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.cpp

HerrCai0907 · 2025-03-06T15:08:11Z

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.h

+public:
+  UseCppStyleCommentsCheck(StringRef Name, ClangTidyContext *Context);
+
+  ~UseCppStyleCommentsCheck() override;


It is not need to override default destructor

Done Thanks!

The virtual destructor of the UseCppStyleCommentsCheck will need size of class CStyleCommentHandler cause the destructor of unique_ptr Handler will try to destroy class CStyleCommentHandler. This is a issue like due to forward declaration of the member class CStyleCommentHandler.

clang-tools-extra/clang-tidy/readability/UseCppStyleCommentsCheck.cpp

clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-style-comments.rst

clang-tools-extra/docs/ReleaseNotes.rst

4m4n-x-B4w4ne · 2025-03-20T07:10:44Z

Can anyone please tell me what to be done next? @EugeneZelenko @HerrCai0907 @PiotrZSL

clang-tools-extra/docs/ReleaseNotes.rst

clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-style-comments.rst

Co-authored-by: EugeneZelenko <eugene.zelenko@gmail.com>

…tyle-comments.rst Co-authored-by: EugeneZelenko <eugene.zelenko@gmail.com>

4m4n-x-B4w4ne · 2025-03-23T19:08:51Z

If everything looks good, then can it be merged? @PiotrZSL @HerrCai0907 @EugeneZelenko

4m4n-x-B4w4ne · 2025-04-02T11:27:22Z

Can anyone please guide me for what to be done next? @EugeneZelenko @HerrCai0907 @vbvictor @PiotrZSL

vbvictor · 2025-04-02T20:20:38Z

I think we should wait from re-review from PiotrZSL, then it will be ready to merge

vbvictor

LGTM with minor docs issues/suggestions.
If there wouldn't be any new reviews in the upcoming month, I think we should merge this check before LLVM21 is released.

clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-style-comments.rst

clang-tools-extra/test/clang-tidy/checkers/readability/use-cpp-style-comments.cpp

fmt'

clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-style-comments.rst

…-style-comments.cpp adding support for c++98 or later Co-authored-by: Baranov Victor <bar.victor.2002@gmail.com>

…tyle-comments.rst fmt' Co-authored-by: EugeneZelenko <eugene.zelenko@gmail.com>

4m4n-x-B4w4ne · 2025-06-03T15:49:15Z

LGTM with minor docs issues/suggestions. If there wouldn't be any new reviews in the upcoming month, I think we should merge this check before LLVM21 is released.

Yeah sure!

vbvictor · 2025-06-03T16:59:49Z

Ping @PiotrZSL @carlosgalvezp If you wish to review this check

@4m4n-x-B4w4ne, note that tests failed (probably because of c++98..)

4m4n-x-B4w4ne · 2025-06-03T17:12:56Z

Ping @PiotrZSL @carlosgalvezp If you wish to review this check

@4m4n-x-B4w4ne, note that tests failed (probably because of c++98..)

it failed before this c++98orlater commit too. Maybe their is some merges in the meantime that is causing this issue. I am checking it.

chaitanyav and others added 3 commits January 24, 2025 22:53

This commit is to resolve the issue llvm#24841

581cc0e

Revert "Added options to readability-implicit-bool-conversion (llvm#1…

8bf94c6

…20087)" This reverts commit 5bec2b7. reverting previous commits on this branch

Merge branch 'llvm:main' into issue_24841

eb4dd90

llvmbot added clang-tools-extra clang-tidy labels Jan 24, 2025

4m4n-x-B4w4ne added 3 commits January 24, 2025 23:48

Fixed formatting issues

4a87afe

Fixed Formatting issues

44d208e

Fixed Formatting issue

c9a20ef

Fixed Formating issues

ec6a689

vbvictor reviewed Jan 24, 2025

View reviewed changes

clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp Outdated Show resolved Hide resolved

vbvictor reviewed Jan 24, 2025

View reviewed changes

clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.h Outdated Show resolved Hide resolved

vbvictor reviewed Jan 24, 2025

View reviewed changes

clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp Outdated Show resolved Hide resolved

vbvictor reviewed Jan 24, 2025

View reviewed changes

clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.cpp Outdated Show resolved Hide resolved

HerrCai0907 reviewed Jan 25, 2025

View reviewed changes

EugeneZelenko reviewed Jan 25, 2025

View reviewed changes

EugeneZelenko requested review from PiotrZSL, carlosgalvezp and 5chmidti January 25, 2025 14:46

further improvements as suggested

c815e43

4m4n-x-B4w4ne added 2 commits January 27, 2025 22:35

Delete clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsChec…

47217aa

…k.cpp

Delete clang-tools-extra/clang-tidy/modernize/UseCppStyleCommentsCheck.h

7150e04

EugeneZelenko reviewed Jan 27, 2025

View reviewed changes

4m4n-x-B4w4ne added 2 commits January 27, 2025 23:59

improvements as suggested

ba3c7bb

Fixed Formatting issues

3d02ecd

EugeneZelenko reviewed Jan 27, 2025

View reviewed changes

nikic removed their request for review February 9, 2025 14:05

PiotrZSL reviewed Feb 10, 2025

View reviewed changes

further modifications

0dfe661

EugeneZelenko reviewed Feb 17, 2025

View reviewed changes

clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-style-comments.rst Outdated Show resolved Hide resolved

fmt'

cc9249d

HerrCai0907 approved these changes Mar 6, 2025

View reviewed changes

EugeneZelenko reviewed Mar 6, 2025

View reviewed changes

clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-style-comments.rst Outdated Show resolved Hide resolved

4m4n-x-B4w4ne added 4 commits March 16, 2025 03:11

fmt'

43aff62

Merge branch 'main' into issue_24841

2d4aee8

fmt'

5ffdc17

fmt'

78fc4c9

EugeneZelenko reviewed Mar 15, 2025

View reviewed changes

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

4m4n-x-B4w4ne added 2 commits March 16, 2025 13:20

fmt'

cdb6b9a

added override

d027247

EugeneZelenko reviewed Mar 20, 2025

View reviewed changes

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-style-comments.rst Outdated Show resolved Hide resolved

4m4n-x-B4w4ne and others added 2 commits March 20, 2025 22:16

Update clang-tools-extra/docs/ReleaseNotes.rst

84caead

Co-authored-by: EugeneZelenko <eugene.zelenko@gmail.com>

Update clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-s…

0935e58

…tyle-comments.rst Co-authored-by: EugeneZelenko <eugene.zelenko@gmail.com>

vbvictor approved these changes Jun 3, 2025

View reviewed changes

Update use-cpp-style-comments.rst

317ee60

fmt'

EugeneZelenko reviewed Jun 3, 2025

View reviewed changes

clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-style-comments.rst Show resolved Hide resolved

4m4n-x-B4w4ne and others added 2 commits June 3, 2025 21:16

Update clang-tools-extra/test/clang-tidy/checkers/readability/use-cpp…

d8d3d2c

…-style-comments.cpp adding support for c++98 or later Co-authored-by: Baranov Victor <bar.victor.2002@gmail.com>

Update clang-tools-extra/docs/clang-tidy/checks/readability/use-cpp-s…

884356f

…tyle-comments.rst fmt' Co-authored-by: EugeneZelenko <eugene.zelenko@gmail.com>

[clang-tidy] Replace /* ... */ single-line comments with // ... comments #124319

Are you sure you want to change the base?

[clang-tidy] Replace /* ... */ single-line comments with // ... comments #124319

Uh oh!

Conversation

4m4n-x-B4w4ne commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vbvictor commented Jan 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

4m4n-x-B4w4ne commented Jan 27, 2025

Uh oh!

vbvictor commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PiotrZSL left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4m4n-x-B4w4ne Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

4m4n-x-B4w4ne commented Mar 6, 2025

Uh oh!

HerrCai0907 left a comment

4m4n-x-B4w4ne commented Jan 24, 2025 •

edited

Loading

llvmbot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

vbvictor commented Jan 27, 2025 •

edited

Loading

4m4n-x-B4w4ne Feb 23, 2025 •

edited

Loading

vbvictor commented Jun 3, 2025 •

edited

Loading