Skip to content

[NFC][YAML] Add IO::error() #123475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[NFC][YAML] Add IO::error() #123475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llvm/include/llvm/Support/YAMLTraits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,6 +819,7 @@ class IO {
virtual NodeKind getNodeKind() = 0;

virtual void setError(const Twine &) = 0;
virtual std::error_code error() = 0;
virtual void setAllowUnknownKeys(bool Allow);

template <typename T>
Expand Down Expand Up @@ -1448,7 +1449,7 @@ class Input : public IO {
~Input() override;

// Check if there was an syntax or semantic error during parsing.
std::error_code error();
std::error_code error() override;

private:
bool outputting() const override;
Expand Down Expand Up @@ -1631,6 +1632,7 @@ class Output : public IO {
void scalarTag(std::string &) override;
NodeKind getNodeKind() override;
void setError(const Twine &message) override;
std::error_code error() override;
bool canElideEmptySequence() override;

// These are only used by operator<<. They could be private
Expand Down
2 changes: 2 additions & 0 deletions llvm/lib/Support/YAMLTraits.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,8 @@ void Output::scalarTag(std::string &Tag) {
void Output::setError(const Twine &message) {
}

std::error_code Output::error() { return {}; }

bool Output::canElideEmptySequence() {
// Normally, with an optional key/value where the value is an empty sequence,
// the whole key/value can be not written. But, that produces wrong yaml
Expand Down
Loading