Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb/crashlog] Fix typo in error message when creating a target #122514

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

medismailben
Copy link
Member

This fixes a typo when creating a target from the crashlog script and that we were not able to find a valid architecture from the crash report.

rdar://137344016

This fixes a typo when creating a target from the crashlog script and
that we were not able to find a valid architecture from the crash report.

rdar://137344016

Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
@llvmbot
Copy link
Member

llvmbot commented Jan 10, 2025

@llvm/pr-subscribers-lldb

Author: Med Ismail Bennani (medismailben)

Changes

This fixes a typo when creating a target from the crashlog script and that we were not able to find a valid architecture from the crash report.

rdar://137344016


Full diff: https://github.com/llvm/llvm-project/pull/122514.diff

1 Files Affected:

  • (modified) lldb/examples/python/crashlog.py (+1-1)
diff --git a/lldb/examples/python/crashlog.py b/lldb/examples/python/crashlog.py
index 368437ed63e46b..ab8c2fcaf034b2 100755
--- a/lldb/examples/python/crashlog.py
+++ b/lldb/examples/python/crashlog.py
@@ -1512,7 +1512,7 @@ def load_crashlog_in_scripted_process(debugger, crashlog_path, options, result):
         arch = crashlog.process_arch
         if not arch:
             raise InteractiveCrashLogException(
-                "couldn't create find the architecture to create the target"
+                "couldn't find the architecture to create the target"
             )
         target = debugger.CreateTargetWithFileAndArch(None, arch)
     # 4. Fail

Copy link
Contributor

@chelcassanova chelcassanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@medismailben medismailben merged commit 833a174 into llvm:main Jan 10, 2025
7 of 8 checks passed
medismailben added a commit to medismailben/llvm-project that referenced this pull request Jan 10, 2025
…m#122514)

This fixes a typo when creating a target from the crashlog script and
that we were not able to find a valid architecture from the crash
report.

rdar://137344016

Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
medismailben added a commit to medismailben/llvm-project that referenced this pull request Jan 10, 2025
…m#122514)

This fixes a typo when creating a target from the crashlog script and
that we were not able to find a valid architecture from the crash
report.

rdar://137344016

Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
(cherry picked from commit 833a174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants