-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc][docs] Add net/if.h documentation by referring to POSIX standards #122406
Conversation
…clude it in index
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@llvm/pr-subscribers-libc Author: Prashanth (StarOne01) ChangesThis pull request introduces the following changes to the project:
Purpose:
Testing:
Full diff: https://github.com/llvm/llvm-project/pull/122406.diff 3 Files Affected:
diff --git a/libc/docs/CMakeLists.txt b/libc/docs/CMakeLists.txt
index 5a3f8275bb932e..a21d8e563626c5 100644
--- a/libc/docs/CMakeLists.txt
+++ b/libc/docs/CMakeLists.txt
@@ -19,6 +19,7 @@ if (SPHINX_FOUND)
file(MAKE_DIRECTORY
"${CMAKE_CURRENT_BINARY_DIR}/headers/arpa/"
"${CMAKE_CURRENT_BINARY_DIR}/headers/sys/"
+ "${CMAKE_CURRENT_BINARY_DIR}/headers/net/"
)
# Change sphinx to build from $build_dir/libc/docs/ rather than
@@ -40,6 +41,7 @@ if (SPHINX_FOUND)
float
inttypes
locale
+ net/if
setjmp
signal
stdbit
diff --git a/libc/docs/headers/index.rst b/libc/docs/headers/index.rst
index 07ab6dd9b26742..b78ae86e968d9a 100644
--- a/libc/docs/headers/index.rst
+++ b/libc/docs/headers/index.rst
@@ -14,6 +14,7 @@ Implementation Status
inttypes
locale
math/index.rst
+ net/if
search
setjmp
signal
diff --git a/libc/utils/docgen/net/if.yaml b/libc/utils/docgen/net/if.yaml
new file mode 100644
index 00000000000000..085d27b2bb94fa
--- /dev/null
+++ b/libc/utils/docgen/net/if.yaml
@@ -0,0 +1,13 @@
+functions:
+ if_freenameindex:
+ in-latest-posix: ''
+ if_indextoname:
+ in-latest-posix: ''
+ if_nameindex:
+ in-latest-posix: ''
+ if_nametoindex:
+ in-latest-posix: ''
+
+macros:
+ IF_NAMESIZE:
+ in-latest-posix: ''
\ No newline at end of file
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks. Need us to merge this for you?
Yes, please! |
@StarOne01 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
This pull request introduces the following changes to the project with reference to issue ( #122006 ):
Documentation Update:
if.yaml
undernet
to document network interface functions and macros.if.yaml
file includes the following functions and macros:if_freenameindex
if_indextoname
if_nameindex
if_nametoindex
IF_NAMESIZE
CMake Configuration Update:
CMakeLists.txt
file to create the necessary directory for thenet
headers.net/if
documentation in the Sphinx build configuration.Index Update:
index.rst
file to include a reference to the newly addednet/if
documentation.Purpose:
Testing:
index.rst
.