-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sanitizer] Parse weighted sanitizer args and -fsanitize-skip-hot-cutoff #121619
Merged
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
ca1fabc
[sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot
thurstond 7701659
clang-format
thurstond ade9e63
Update flag description
thurstond 6e20cf8
Plumb values through CodeGen
thurstond cc3a2ac
clang-format
thurstond 9a2a0e8
using SanitizerMaskWeights = std::array<float, SanitizerKind::SO_Count>
thurstond bfa57c6
clang-format
thurstond 346adc1
Rename Weights to Cutoffs
thurstond 66dbc49
Limit changes to Driver
thurstond 6f5e714
Reorder to make comment more logical
thurstond fc623f2
Refactor into parseArgCutoffs; update comment
thurstond 00d135e
Remove unnecessary suppression
thurstond 4d97bed
clang-format
thurstond 1f528c5
Change Cutoffs* to Cutoffs&
thurstond 071e10e
Remove SanitizerMask TopHot
thurstond c970179
Rely on RVO
thurstond b2bb1d6
Fix uninitialized memory
thurstond 369e6c8
clang-format
thurstond c6d4e73
Allow passing -fno-sanitize-top-hot=undefined=0.0. Add more tests.
thurstond 85b898c
Check cutoffs in parsing. Update tests.
thurstond 6cd43bb
Change cutoffs parser to return an empty SanitizerMask (Cutoffs becom…
thurstond c4b6a68
Simplify parseNoSanitizeHotArgs by not relying on parseSanitizeArgs
thurstond 57d6c59
Change parseArgCutoffs to void return
thurstond 56ba349
Convert SanitizerMaskCutoffs to struct
thurstond 2298f93
Omit redundant initialization
thurstond a5ff144
Remove unnecessary braces
thurstond 46e90e5
Rename 'data' to 'cutoffs'
thurstond 58550e9
Improve comment
vitalybuka b2f0e5d
Make SanitizerMaskCutoffs class
vitalybuka be0f4e8
Remove unrelated change
vitalybuka a21c77b
Simplify parseSanitizerWeightedValue
vitalybuka 27fe651
Fix clamp call
vitalybuka 45a9fa5
Whitespace
thurstond 5ab2a2b
Fix case in comment
vitalybuka a9c8d58
Hide clear logic into SanitizerMaskCutoffs
vitalybuka b668bcb
use string::empty
vitalybuka 9321def
Return SanitizerMaskCutoffs from parseNoSanitizeHotArgs by value
vitalybuka d39638d
Extract ::set
vitalybuka 99cfdb2
return float by value
vitalybuka 58c752b
Updates
vitalybuka f27eb85
Include
vitalybuka 1aed608
Fix clamp for double
vitalybuka b82e48d
Format
vitalybuka a8e79ce
Claim matched arguments
thurstond d3fa04d
Change test to use -Werror and not check for error messages, per Fang…
thurstond 55f42e7
Format
vitalybuka d8a3696
This reverts part of commit b82e48d83663afead2b5b0ed4c5f2fb2b32683ad.
vitalybuka 17ecca4
rtrim('0')
vitalybuka b43d513
clang-format
vitalybuka caa4964
Rename -fno-sanitize-top-hot to -fsanitize-skip-hot-cutoff
thurstond 9837912
clang-format
thurstond 10e0a55
++clang
thurstond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Hide clear logic into SanitizerMaskCutoffs
- Loading branch information
commit a9c8d582f5a3304fa1a12aabcf93df4f5a9a05eb
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llvm prefer ++i
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 10e0a55. Thanks for the review!