[mlir][vector] Restrict vector.insert/vector.extract #121458
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While the discussion is ongoing, I am posting this as draft. Please comment either here or on Discourse. |
banach-space
force-pushed
the
andrzej/restrict_vec_insert_extract
branch
from
0962edb to
473bd0f
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
banach-space
force-pushed
the
andrzej/restrict_vec_insert_extract
branch
from
473bd0f to
9434337
Compare
banach-space
force-pushed
the
andrzej/restrict_vec_insert_extract
branch
from
9434337 to
eb62bf0
Compare
banach-space
force-pushed
the
andrzej/restrict_vec_insert_extract
branch
from
eb62bf0 to
4084038
Compare
banach-space
force-pushed
the
andrzej/restrict_vec_insert_extract
branch
from
4084038 to
c214bbf
Compare
This patch restricts the use of vector.insert and vector.extract Ops in
the Vector dialect. Specifically:
* The non-indexed operands for `vector.insert` and `vector.extract`
must now be non-0-D vectors.
The following are now illegal. Note that the source and result types
(i.e. non-indexed args) are rank-0 vectors:
```mlir
%0 = vector.insert %v, %dst[0, 0] : vector<f32> into vector<2x2xf32>
%1 = vector.extract %arg0[0, 0] : vector<f32> from vector<2x2xf32>
```
Instead, use scalars as the source and result types:
```mlir
%0 = vector.insert %v, %dst[0, 0] : f32 into vector<2x2xf32>
%1 = vector.extract %src[0, 0] : f32 from vector<2x2xf32>
```
Put differently, this PR removes the ambiguity when it comes to
non-indexed operands of `vector.insert` and `vector.extract`. By
requiring that only one form is used, it eliminates the flexibility of
allowing both, thereby simplifying the semantics.
For more context, see the related RFC:
* https://discourse.llvm.org/t/rfc-should-we-restrict-the-usage-of-0-d-vectors-in-the-vector-dialect
banach-space
force-pushed
the
andrzej/restrict_vec_insert_extract
branch
from
c214bbf to
29e7bb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch restricts the use of vector.insert and vector.extract Ops in
the Vector dialect. Specifically:
vector.insertandvector.extractmust now be non-0-D vectors.
The following are now illegal. Note that the source and result types
(i.e. non-indexed args) are rank-0 vectors:
Instead, use scalars as the source and result types:
Put differently, this PR removes the ambiguity when it comes to
non-indexed operands of
vector.insertandvector.extract. Byrequiring that only one form is used, it eliminates the flexibility of
allowing both, thereby simplifying the semantics.
For more context, see the related RFC: