Skip to content

[Telemetry] Add missing virtual destructors #121015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vitalybuka
Copy link
Collaborator

Fixes warnings after #121003.

Created using spr 1.3.4
@vitalybuka vitalybuka added the skip-precommit-approval PR for CI feedback, not intended for review label Dec 24, 2024
@vitalybuka vitalybuka merged commit 9d0a5d4 into main Dec 24, 2024
7 of 10 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/telemetry-add-missing-virtual-destructors branch December 24, 2024 00:29
@oontvoo
Copy link
Member

oontvoo commented Dec 24, 2024

Thank you!

@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 24, 2024

LLVM Buildbot has detected a new failure on builder ml-opt-dev-x86-64 running on ml-opt-dev-x86-64-b1 while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/137/builds/10828

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM :: ExecutionEngine/JITLink/x86-64/LocalDependencyPropagation.s' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 2: /b/ml-opt-dev-x86-64-b1/build/bin/llvm-mc -triple=x86_64-apple-macosx10.9 -filetype=obj -o /b/ml-opt-dev-x86-64-b1/build/test/ExecutionEngine/JITLink/x86-64/Output/LocalDependencyPropagation.s.tmp /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/LocalDependencyPropagation.s
+ /b/ml-opt-dev-x86-64-b1/build/bin/llvm-mc -triple=x86_64-apple-macosx10.9 -filetype=obj -o /b/ml-opt-dev-x86-64-b1/build/test/ExecutionEngine/JITLink/x86-64/Output/LocalDependencyPropagation.s.tmp /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/LocalDependencyPropagation.s
RUN: at line 3: /b/ml-opt-dev-x86-64-b1/build/bin/llvm-jitlink -debug-only=orc -noexec -abs _external_func=0x1    -entry=_foo /b/ml-opt-dev-x86-64-b1/build/test/ExecutionEngine/JITLink/x86-64/Output/LocalDependencyPropagation.s.tmp 2>&1 | /b/ml-opt-dev-x86-64-b1/build/bin/FileCheck /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/LocalDependencyPropagation.s
+ /b/ml-opt-dev-x86-64-b1/build/bin/llvm-jitlink -debug-only=orc -noexec -abs _external_func=0x1 -entry=_foo /b/ml-opt-dev-x86-64-b1/build/test/ExecutionEngine/JITLink/x86-64/Output/LocalDependencyPropagation.s.tmp
+ /b/ml-opt-dev-x86-64-b1/build/bin/FileCheck /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/LocalDependencyPropagation.s
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/LocalDependencyPropagation.s:13:10: error: CHECK: expected string not found in input
# CHECK: In main emitting {{.*}}_foo{{.*}}
         ^
<stdin>:1:1: note: scanning from here
Defining MU <Absolute Symbols> for main (tracker: 0x0, default will be used)
^
<stdin>:38:1: note: possible intended match here
In main defining materializing symbols { }
^

Input file: <stdin>
Check file: /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/test/ExecutionEngine/JITLink/x86-64/LocalDependencyPropagation.s

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            1: Defining MU <Absolute Symbols> for main (tracker: 0x0, default will be used) 
check:13'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
            2:  { ("_external_func", [Data]) } 
check:13'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            3: Defining MU /b/ml-opt-dev-x86-64-b1/build/test/ExecutionEngine/JITLink/x86-64/Output/LocalDependencyPropagation.s.tmp for main (tracker: default) { ("_baz", [Callable]), ("_foo", [Callable]) } 
check:13'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            4: Looking up { (_foo, RequiredSymbol) } in [ ("main", MatchAllSymbols), ("Process", MatchExportedSymbolsOnly) ] (required state: Ready) 
check:13'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            5: Dispatching MaterializationUnits... 
check:13'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            6: Done dispatching MaterializationUnits. 
check:13'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            .
            .
            .
           33: No dependencies to register 
check:13'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           34: Dispatching MaterializationUnits... 
check:13'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           35:  Dispatching "/b/ml-opt-dev-x86-64-b1/build/test/ExecutionEngine/JITLink/x86-64/Output/LocalDependencyPropagation.s.tmp" 
check:13'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           36: Dispatching: Materialization task: /b/ml-opt-dev-x86-64-b1/build/test/ExecutionEngine/JITLink/x86-64/Output/LocalDependencyPropagation.s.tmp in main 
check:13'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...

@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 24, 2024

LLVM Buildbot has detected a new failure on builder clang-ppc64le-linux-test-suite running on ppc64le-clang-test-suite while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/95/builds/7736

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'ORC-powerpc64le-linux :: TestCases/Linux/ppc64/trivial-tls-pwr10.test' FAILED ********************
Exit Code: 139

Command Output (stderr):
--
RUN: at line 1: rm -rf /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp && mkdir -p /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp
+ rm -rf /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp
+ mkdir -p /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp
RUN: at line 2: /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./bin/clang  --driver-mode=g++  -m64 -fno-function-sections  -fPIC -c -o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp/main.o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/test/orc/TestCases/Linux/ppc64/Inputs/trivial-tls-main.cpp
+ /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./bin/clang --driver-mode=g++ -m64 -fno-function-sections -fPIC -c -o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp/main.o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/test/orc/TestCases/Linux/ppc64/Inputs/trivial-tls-main.cpp
RUN: at line 3: /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./bin/clang  --driver-mode=g++  -m64 -fno-function-sections  -fPIC -c -o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp/pwr10.o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/test/orc/TestCases/Linux/ppc64/Inputs/trivial-tls-pwr10.cpp
+ /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./bin/clang --driver-mode=g++ -m64 -fno-function-sections -fPIC -c -o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp/pwr10.o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/test/orc/TestCases/Linux/ppc64/Inputs/trivial-tls-pwr10.cpp
RUN: at line 4: /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./bin/llvm-jitlink -orc-runtime=/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./lib/../lib/clang/20/lib/powerpc64le-unknown-linux-gnu/liborc_rt.a /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp/main.o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp/pwr10.o
+ /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./bin/llvm-jitlink -orc-runtime=/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./lib/../lib/clang/20/lib/powerpc64le-unknown-linux-gnu/liborc_rt.a /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp/main.o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp/pwr10.o
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.script: line 4: 2820159 Segmentation fault      (core dumped) /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./bin/llvm-jitlink -orc-runtime=/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./lib/../lib/clang/20/lib/powerpc64le-unknown-linux-gnu/liborc_rt.a /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp/main.o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/orc/POWERPC64LELinuxConfig/TestCases/Linux/ppc64/Output/trivial-tls-pwr10.test.tmp/pwr10.o

--

********************


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-precommit-approval PR for CI feedback, not intended for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants