Skip to content

[LLVM] Update exception handling maintainer #120585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Dec 19, 2024

We currently list @asl as the maintainer for exception handling, but I don't think he has been particularly involved in that area in recent years. Please correct me if I'm wrong!

I'd like to nominate @efriedma-quic as the replacement. I think Eli is familiar with all our exception mechanisms and a good choice of reviewer for related PRs.

@nikic nikic requested review from asl and efriedma-quic December 19, 2024 14:35
@efriedma-quic
Copy link
Collaborator

I'm not sure "exception handling" is the right way to define the area. On the LLVM side, DWARF EH and WinEH live in mostly parallel worlds: the IR constructs are different, and the code generator codepaths are mostly independent. I'm happy to pick up WinEH, but I don't want to spread myself too thin, and I think there are probably better alternatives for DWARF EH.

CC @rnk @mstorsjo @phoebewang @dwblaikie

@asl
Copy link
Collaborator

asl commented Dec 20, 2024

@efriedma-quic is correct. Historically "exception handling" was Dwarf EH. Even on Windows we used Dwarf EH in mingw world. All Windows-related constructs appeared much later (and their semantics is indeed different).

@dwblaikie
Copy link
Collaborator

Yeah, not sure who'd be best for DWARF EH - @MaskRay has reviewed some patches in that area lately, but maybe there's someone else with more bandwidth?

@rnk
Copy link
Collaborator

rnk commented Jan 24, 2025

I have a pretty decent understanding of how both systems (WinEH and DWARF) work and I would volunteer to write my name down for exception handling. I can't speak to the other platform specific unwind info formats (MachO compact unwind and ARM), but that's less relevant here.

@nikic nikic force-pushed the exception-handling-maintainer branch from 83ca806 to 11888bb Compare January 29, 2025 14:30
@nikic nikic merged commit fffa68a into llvm:main Jan 30, 2025
8 checks passed
@nikic nikic deleted the exception-handling-maintainer branch January 30, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants