Reland (#120419):[Exegesis][RISCV] Add RISCV support for llvm-exegesis #120467

dybv-sc · 2024-12-18T19:00:03Z

2nd reland attempt. This should be merged again and applying #120451 should fix buildbot issue.

Original commit message:

[Exegesis][RISCV] Add RISCV support for llvm-exegesis (https://github.com/llvm/llvm-project/pull/89047)
This patch also makes following amendments to core exegesis:
* Added distinction between regular registers aliasing check and
registers used as memory address in instruction.
* Added scratch memory space pointer register.
* General exegesis options were amended:
        * mattr - new option to pass a list of enabled target features

Llvm-exegesis RISCV port is a result of team effort. Below everyone
involved listed.
Co-authored-by: Konstantin Vladimirov
<konstantin.vladimirov@syntacore.com>
Co-authored-by: Dmitrii Petrov <dmitrii.petrov@syntacore.com>
Co-authored-by: Dmitry Bushev <dmitry.bushev@syntacore.com>
Co-authored-by: Mark Goncharov <mark.goncharov@syntacore.com>
Co-authored-by: Anastasiya Chernikova
<anastasiya.chernikova@syntacore.com>

---------

Co-authored-by: Dmitry Bushev <dmitry.bushev@syntacore.com>

This patch also makes following amendments to core exegesis: * Added distinction between regular registers aliasing check and registers used as memory address in instruction. * Added scratch memory space pointer register. * Added ability for targets to define register name to register number mapping (findRegisterByName). * General exegesis options were amended: * mattr - new option to pass a list of enabled target features * opcode-name - this option is amended to accept range of opcodes at once Llvm-exegesis RISCV port is a result of team effort. Below everyone involved listed. Co-authored-by: Konstantin Vladimirov <konstantin.vladimirov@syntacore.com> Co-authored-by: Dmitrii Petrov <dmitrii.petrov@syntacore.com> Co-authored-by: Dmitry Bushev <dmitry.bushev@syntacore.com> Co-authored-by: Mark Goncharov <mark.goncharov@syntacore.com> Co-authored-by: Anastasiya Chernikova <anastasiya.chernikova@syntacore.com>

dybv-sc · 2024-12-18T19:01:40Z

@boomanaiden154 , @thurstond, @kazutakahirata FYI

kazutakahirata · 2024-12-18T19:07:17Z

@dybv-sc Thanks for the update! When I try out your patch, I am getting:

CMake Error at cmake/modules/LLVMProcessSources.cmake:113 (message):
  Found erroneous configuration for source file RISCVCounters.cpp

  LLVM's build system enforces that all source files are added to a build
  target, that exactly one build target exists in each directory, and that
  this target lists all files in that directory.  If you want multiple
  targets in the same directory, add PARTIAL_SOURCES_INTENDED to the target
  specification, though it is discouraged.

I'm guessing that llvm/tools/llvm-exegesis/lib/RISCV/CMakeLists.txt should somehow mention RISCVCounters.cpp. Thoughts?

dybv-sc · 2024-12-18T19:34:17Z

@dybv-sc Thanks for the update! When I try out your patch, I am getting:

CMake Error at cmake/modules/LLVMProcessSources.cmake:113 (message):
  Found erroneous configuration for source file RISCVCounters.cpp

  LLVM's build system enforces that all source files are added to a build
  target, that exactly one build target exists in each directory, and that
  this target lists all files in that directory.  If you want multiple
  targets in the same directory, add PARTIAL_SOURCES_INTENDED to the target
  specification, though it is discouraged.

I'm guessing that llvm/tools/llvm-exegesis/lib/RISCV/CMakeLists.txt should somehow mention RISCVCounters.cpp. Thoughts?

Hi,

Have you applied all of the patches there are in this request? We used to have this file, but after some discussion, we removed it (with the intention to rework and bring it back in some later request). Currently there should be no this file on top of our branch.

boomanaiden154 · 2024-12-18T19:37:11Z

llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp

+                     RISCV_MC::isOpcodeAvailable) {}
+
+#define GET_REGISTER_MATCHER
+#include "RISCVGenAsmMatcher.inc"


This should be removed before relanding. It doesn't make sense to land with a forward fix already planned.

You are right, amended Kazu's fix

LGTM. Please update the commit message before merging.

authored-by: Kazu Hirata <kazu@google.com>

boomanaiden154

LGTM.

kazutakahirata · 2024-12-18T20:09:53Z

@dybv-sc Thanks for the update! When I try out your patch, I am getting:
CMake Error at cmake/modules/LLVMProcessSources.cmake:113 (message):
  Found erroneous configuration for source file RISCVCounters.cpp

  LLVM's build system enforces that all source files are added to a build
  target, that exactly one build target exists in each directory, and that
  this target lists all files in that directory.  If you want multiple
  targets in the same directory, add PARTIAL_SOURCES_INTENDED to the target
  specification, though it is discouraged.
I'm guessing that llvm/tools/llvm-exegesis/lib/RISCV/CMakeLists.txt should somehow mention RISCVCounters.cpp. Thoughts?
Hi,

Have you applied all of the patches there are in this request? We used to have this file, but after some discussion, we removed it (with the intention to rework and bring it back in some later request). Currently there should be no this file on top of our branch.

Huh. When I applied https://github.com/llvm/llvm-project/pull/120467.patch locally, that didn't work. When I applied https://github.com/llvm/llvm-project/pull/120467.diff, however, that did work. I didn't know there was a difference between patch and diff.

Anyway, thank you for updating the patch!

kazutakahirata

LGTM. Thanks!

llvm-ci · 2024-12-18T23:08:18Z

LLVM Buildbot has detected a new failure on builder lldb-arm-ubuntu running on linaro-lldb-arm-ubuntu while building llvm at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/8788

Here is the relevant piece of the build log for the reference

Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: tools/lldb-dap/instruction-breakpoint/TestDAP_instruction_breakpoint.py (1142 of 2856)
PASS: lldb-api :: tools/lldb-dap/locations/TestDAP_locations.py (1143 of 2856)
PASS: lldb-api :: tools/lldb-dap/memory/TestDAP_memory.py (1144 of 2856)
PASS: lldb-api :: tools/lldb-dap/optimized/TestDAP_optimized.py (1145 of 2856)
PASS: lldb-api :: tools/lldb-dap/output/TestDAP_output.py (1146 of 2856)
PASS: lldb-api :: tools/lldb-dap/module/TestDAP_module.py (1147 of 2856)
PASS: lldb-api :: tools/lldb-dap/evaluate/TestDAP_evaluate.py (1148 of 2856)
PASS: lldb-api :: tools/lldb-dap/repl-mode/TestDAP_repl_mode_detection.py (1149 of 2856)
UNSUPPORTED: lldb-api :: tools/lldb-dap/restart/TestDAP_restart_runInTerminal.py (1150 of 2856)
UNSUPPORTED: lldb-api :: tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py (1151 of 2856)
FAIL: lldb-api :: tools/lldb-dap/launch/TestDAP_launch.py (1152 of 2856)
******************** TEST 'lldb-api :: tools/lldb-dap/launch/TestDAP_launch.py' FAILED ********************
Script:
--
/usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin --arch armv8l --build-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./lib /home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/tools/lldb-dap/launch -p TestDAP_launch.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 20.0.0git (https://github.com/llvm/llvm-project.git revision 8e8692a542037056b332f4a3b5f12441267b76eb)
  clang revision 8e8692a542037056b332f4a3b5f12441267b76eb
  llvm revision 8e8692a542037056b332f4a3b5f12441267b76eb
Skipping the following test categories: ['libc++', 'dsym', 'gmodules', 'debugserver', 'objc']
========= DEBUG ADAPTER PROTOCOL LOGS =========
1734563122.495487213 --> 
Content-Length: 344

{
  "arguments": {
    "adapterID": "lldb-native",
    "clientID": "vscode",
    "columnsStartAt1": true,
    "linesStartAt1": true,
    "locale": "en-us",
    "pathFormat": "path",
    "sourceInitFile": false,
    "supportsRunInTerminalRequest": true,
    "supportsStartDebuggingRequest": true,
    "supportsVariablePaging": true,
    "supportsVariableType": true
  },
  "command": "initialize",
  "seq": 1,
  "type": "request"
}
1734563122.497909546 <-- 
Content-Length: 1589

llvm-ci · 2024-12-20T10:33:28Z

LLVM Buildbot has detected a new failure on builder lld-x86_64-win running on as-worker-93 while building llvm at step 7 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/1878

Here is the relevant piece of the build log for the reference

Step 7 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM-Unit :: Support/./SupportTests.exe/38/87' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe-LLVM-Unit-20892-38-87.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=87 GTEST_SHARD_INDEX=38 C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe
--

Script:
--
C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe --gtest_filter=ProgramEnvTest.CreateProcessLongPath
--
C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(160): error: Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(163): error: fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied



C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:160
Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:163
fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied




********************

AnastasiyaChernikova and others added 30 commits November 26, 2024 17:29

Addressing review comments

68bef56

Addressing review comments

22dc529

Addressing review comments

3050772

Fixed tests

9c289b8

Addressing review comments

1277beb

Addressing review comments

712aa9d

Addressing review comments

84db7eb

Addressing review comments

99bccdd

Addressing review comments

9352f6d

Addressing review comments

d52ddc8

Addressing review comments

49cd463

Fix code format

4004b8a

Addressing review comments

5c2b1ad

Addressing review comments

321f049

Addressing review comments

78d6a0e

Addressing review comments

a650063

Remove performance counters initial support

f35809b

Addressing review comments

6b6c0af

Fix code format

c424403

Addressing review comments

68006e5

Fixed consequences of PR llvm#112314. Removed support for load

2fbe7b9

Addressing review comments

e4fdd4b

Addressing review comments

c2b189e

Addressing review comments

f36c7e8

Deleted processInstructionReservedRegs

eb3bd6f

Addressing review comments

70541d3

Addressing review comments

570fee5

Addressing review comments

c56a94b

Addressing review comments

a0130ea

AnastasiyaChernikova and others added 6 commits December 3, 2024 18:52

Addressing review comments

9859fb6

Addressing review comments

c84e814

Addressing review comments

2a82817

append lit cofig for RISCV tests

3030011

Fix [unused-private-field] error

1dc0a79

Remove unsued variable

22754e3

dybv-sc requested review from thurstond, boomanaiden154 and kazutakahirata December 18, 2024 19:00

boomanaiden154 reviewed Dec 18, 2024

View reviewed changes

Remove no more used includes.

86f59cc

authored-by: Kazu Hirata <kazu@google.com>

dybv-sc force-pushed the riscv_support branch from 3fe9d46 to 86f59cc Compare December 18, 2024 19:56

dybv-sc requested a review from boomanaiden154 December 18, 2024 19:58

boomanaiden154 approved these changes Dec 18, 2024

View reviewed changes

thurstond approved these changes Dec 18, 2024

View reviewed changes

kazutakahirata mentioned this pull request Dec 18, 2024

[llvm-exegesis] Fix warnings #120451

Closed

kazutakahirata approved these changes Dec 18, 2024

View reviewed changes

dybv-sc merged commit 8e8692a into llvm:main Dec 18, 2024
8 checks passed

This was referenced Jun 2, 2025

[MTE] [NFC] use vector to collect globals to tag (#120283) #142329

Closed

[MTE] [NFC] use vector to collect globals to tag (#120283) #142330

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reland (#120419):[Exegesis][RISCV] Add RISCV support for llvm-exegesis #120467

Reland (#120419):[Exegesis][RISCV] Add RISCV support for llvm-exegesis #120467

Uh oh!

dybv-sc commented Dec 18, 2024

Uh oh!

dybv-sc commented Dec 18, 2024

Uh oh!

kazutakahirata commented Dec 18, 2024

Uh oh!

dybv-sc commented Dec 18, 2024

Uh oh!

boomanaiden154 Dec 18, 2024

Uh oh!

dybv-sc Dec 18, 2024

Uh oh!

thurstond Dec 18, 2024

Uh oh!

boomanaiden154 left a comment

Uh oh!

kazutakahirata commented Dec 18, 2024

Uh oh!

kazutakahirata left a comment

Uh oh!

Uh oh!

llvm-ci commented Dec 18, 2024

Uh oh!

llvm-ci commented Dec 20, 2024

Uh oh!

Uh oh!

Reland (#120419):[Exegesis][RISCV] Add RISCV support for llvm-exegesis #120467

Reland (#120419):[Exegesis][RISCV] Add RISCV support for llvm-exegesis #120467

Uh oh!

Conversation

dybv-sc commented Dec 18, 2024

Uh oh!

dybv-sc commented Dec 18, 2024

Uh oh!

kazutakahirata commented Dec 18, 2024

Uh oh!

dybv-sc commented Dec 18, 2024

Uh oh!

boomanaiden154 Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

dybv-sc Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

thurstond Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

boomanaiden154 left a comment

Choose a reason for hiding this comment

Uh oh!

kazutakahirata commented Dec 18, 2024

Uh oh!

kazutakahirata left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

llvm-ci commented Dec 18, 2024

Uh oh!

llvm-ci commented Dec 20, 2024

Uh oh!

Uh oh!