Skip to content

[MLIR][OpenMP] Lowering nontemporal clause to LLVM IR for SIMD directive #118751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 30, 2025
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions flang/include/flang/Optimizer/OpenMP/Passes.td
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,13 @@ def DoConcurrentConversionPass : Pass<"omp-do-concurrent-conversion", "mlir::fun
];
}

def LowerNontemporalPass : Pass<"lower-nontemporal", "mlir::func::FuncOp"> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not run this on omp::SimdOp? Running it on functions is wasteful because many functions will not contain a simd op and runs the risk of missing any simd ops which are not nested inside of functions (I can't see how that would happen currently but we have had problems before lowering non-function (but function-like) operations such as omp.declare_reduction because subsequent passes incorrectly assumed all operations were nested inside of functions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am applying this pass specifically to omp::simdOp, not to all operations within the function. All the nontemporal examples that I referred so far have omp.simd nested inside a function, so I run the pass at the function level, look for omp::simdOp and only add the attribute when such an operation(omp::simdop) is present.

Could you please share an example that explains the scenario "omp.simd" op is not nested inside function?
That would help me to understand better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was only a hypothetical example - I can't think of a case where we would do simd not inside of a function either.

Still, changing this to

def LowerNontemporalPass : Pass<"lower-nontemporal", "mlir::omp::SimdOp"> {

should be a better fit with the intention of the pass, because it will not modify anything outside of the simd op

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically, it could be inside one of the declaration operations (Private, Reduction operations).

BTW, why was this change not made?

Copy link
Contributor

@tblah tblah Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: declaration operations: It could be but I thought that would be so unlikely that it would be better to only make that (minimal) change if it was ever needed.

Re: this thread: Kaviya and I were unable to get it working. It turns out that the MLIR pass manager doesn't allow for arbitrary nesting: only 1 level deep. So you can run a func.func pass on a pass manager for a module because the func.func is a direct descendant. But it couldn't be done for simd because that could be anywhere in the operation tree. I should have posted an update here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Tom!
@kiranchandramohan -- Tom has covered all the points here.

let summary =
"Adds nontemporal attribute to loads and stores performed on "
"the list items specified in the nontemporal clause of omp.simd.";
let dependentDialects = ["mlir::omp::OpenMPDialect"];
}

// Needs to be scheduled on Module as we create functions in it
def LowerWorkshare : Pass<"lower-workshare", "::mlir::ModuleOp"> {
let summary = "Lower workshare construct";
Expand Down
8 changes: 7 additions & 1 deletion flang/lib/Optimizer/CodeGen/CodeGen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3550,7 +3550,13 @@ struct StoreOpConversion : public fir::FIROpConversion<fir::StoreOp> {
newOp = rewriter.create<mlir::LLVM::MemcpyOp>(
loc, llvmMemref, llvmValue, boxSize, /*isVolatile=*/false);
} else {
newOp = rewriter.create<mlir::LLVM::StoreOp>(loc, llvmValue, llvmMemref);
unsigned alignment =
store->getAttrOfType<mlir::IntegerAttr>("alignment")
? store->getAttrOfType<mlir::IntegerAttr>("alignment").getInt()
: 0;
newOp = rewriter.create<mlir::LLVM::StoreOp>(
loc, llvmValue, llvmMemref, alignment, store->hasAttr("volatile"),
store->hasAttr("nontemporal"));
}
if (std::optional<mlir::ArrayAttr> optionalTag = store.getTbaa())
newOp.setTBAATags(*optionalTag);
Expand Down
1 change: 1 addition & 0 deletions flang/lib/Optimizer/OpenMP/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ add_flang_library(FlangOpenMPTransforms
MapInfoFinalization.cpp
MarkDeclareTarget.cpp
LowerWorkshare.cpp
LowerNontemporal.cpp

DEPENDS
FIRDialect
Expand Down
71 changes: 71 additions & 0 deletions flang/lib/Optimizer/OpenMP/LowerNontemporal.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
//===- LowerNontemporal.cpp -------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// Add nontemporal attributes to load and stores of variables marked as
// nontemporal.
//
//===----------------------------------------------------------------------===//
#include "flang/Optimizer/Dialect/FIROpsSupport.h"
#include "flang/Optimizer/OpenMP/Passes.h"
#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
using namespace mlir;
namespace flangomp {
#define GEN_PASS_DEF_LOWERNONTEMPORALPASS
#include "flang/Optimizer/OpenMP/Passes.h.inc"
} // namespace flangomp
namespace {
class LowerNontemporalPass
: public flangomp::impl::LowerNontemporalPassBase<LowerNontemporalPass> {
void addNonTemporalAttr(omp::SimdOp simdOp) {
if (!simdOp.getNontemporalVars().empty()) {
llvm::SmallVector<mlir::Value> nontemporalOrigVars;
mlir::OperandRange nontemporals = simdOp.getNontemporalVars();
for (mlir::Value nontemporal : nontemporals) {
nontemporalOrigVars.push_back(nontemporal);
}
std::function<mlir::Value(mlir::Value)> getBaseOperand =
[&](mlir::Value operand) -> mlir::Value {
if (mlir::isa<fir::DeclareOp>(operand.getDefiningOp()))
return operand;
else if (auto arrayCoorOp = llvm::dyn_cast<fir::ArrayCoorOp>(
operand.getDefiningOp())) {
return getBaseOperand(arrayCoorOp.getMemref());
} else if (auto boxAddrOp = llvm::dyn_cast<fir::BoxAddrOp>(
operand.getDefiningOp())) {
return getBaseOperand(boxAddrOp.getVal());
} else if (auto loadOp =
llvm::dyn_cast<fir::LoadOp>(operand.getDefiningOp())) {
return getBaseOperand(loadOp.getMemref());
} else {
return operand;
}
};
simdOp->walk([&](Operation *op) {
mlir::Value Operand = nullptr;
if (auto loadOp = llvm::dyn_cast<fir::LoadOp>(op)) {
Operand = loadOp.getMemref();
} else if (auto storeOp = llvm::dyn_cast<fir::StoreOp>(op)) {
Operand = storeOp.getMemref();
}
if (Operand && !(fir::isAllocatableType(Operand.getType()) ||
fir::isPointerType((Operand.getType())))) {
Operand = getBaseOperand(Operand);
if (is_contained(nontemporalOrigVars, Operand)) {
// Set the attribute
op->setAttr("nontemporal", UnitAttr::get(op->getContext()));
}
}
});
}
}
void runOnOperation() override {
Operation *op = getOperation();
op->walk([&](omp::SimdOp simdOp) { addNonTemporalAttr(simdOp); });
}
};
} // namespace
4 changes: 3 additions & 1 deletion flang/lib/Optimizer/Passes/Pipelines.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,10 @@ void createHLFIRToFIRPassPipeline(mlir::PassManager &pm, bool enableOpenMP,
addNestedPassToAllTopLevelOperations<PassConstructor>(
pm, hlfir::createInlineHLFIRAssign);
pm.addPass(hlfir::createConvertHLFIRtoFIR());
if (enableOpenMP)
if (enableOpenMP) {
pm.addPass(flangomp::createLowerWorkshare());
pm.addPass(flangomp::createLowerNontemporalPass());
}
}

/// Create a pass pipeline for handling certain OpenMP transformations needed
Expand Down
2 changes: 2 additions & 0 deletions flang/test/Fir/basic-program.fir
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ func.func @_QQmain() {
// PASSES-NEXT: InlineHLFIRAssign
// PASSES-NEXT: ConvertHLFIRtoFIR
// PASSES-NEXT: LowerWorkshare
// PASSES-NEXT: 'func.func' Pipeline
// PASSES-NEXT: LowerNontemporalPass
// PASSES-NEXT: CSE
// PASSES-NEXT: (S) 0 num-cse'd - Number of operations CSE'd
// PASSES-NEXT: (S) 0 num-dce'd - Number of operations DCE'd
Expand Down
67 changes: 67 additions & 0 deletions flang/test/Lower/OpenMP/simd-nontemporal.f90
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
! Test nontemporal clause
! RUN: %flang_fc1 -emit-fir -fopenmp -fopenmp-version=50 %s -o - | FileCheck %s
! RUN: bbc -emit-fir -fopenmp -fopenmp-version=50 %s -o - | FileCheck %s


! CHECK-LABEL: func @_QPsimd_with_nontemporal_clause
subroutine simd_with_nontemporal_clause(n)
! CHECK: %[[A_DECL:.*]] = fir.declare %{{.*}} {uniq_name = "_QFsimd_with_nontemporal_clauseEa"} : (!fir.ref<i32>) -> !fir.ref<i32>
! CHECK: %[[C_DECL:.*]] = fir.declare %{{.*}} {uniq_name = "_QFsimd_with_nontemporal_clauseEc"} : (!fir.ref<i32>) -> !fir.ref<i32>
integer :: i, n
integer :: A, B, C
! CHECK: omp.simd nontemporal(%[[A_DECL]], %[[C_DECL]] : !fir.ref<i32>, !fir.ref<i32>) private(@_QFsimd_with_nontemporal_clauseEi_private_i32 %8 -> %arg1 : !fir.ref<i32>) {
! CHECK-NEXT: omp.loop_nest (%{{.*}}) : i32 = (%{{.*}}) to (%{{.*}}) inclusive step (%{{.*}}) {
!$OMP SIMD NONTEMPORAL(A, C)
do i = 1, n
! CHECK: %[[LOAD:.*]] = fir.load %[[A_DECL]] {nontemporal} : !fir.ref<i32>
C = A + B
! CHECK: %[[ADD_VAL:.*]] = arith.addi %{{.*}}, %{{.*}} : i32
! CHECK: fir.store %[[ADD_VAL]] to %[[C_DECL]] {nontemporal} : !fir.ref<i32>
end do
!$OMP END SIMD
end subroutine

! CHECK-LABEL: func.func @_QPsimd_nontemporal_allocatable
subroutine simd_nontemporal_allocatable(x, y)
integer, allocatable :: x(:)
integer :: y
allocate(x(100))
! CHECK: %[[X_DECL:.*]] = fir.declare %{{.*}} dummy_scope %{{.*}} {fortran_attrs = #fir.var_attrs<allocatable>,
! CHECK-SAME: uniq_name = "_QFsimd_nontemporal_allocatableEx"} : (!fir.ref<!fir.box<!fir.heap<!fir.array<?xi32>>>>, !fir.dscope) -> !fir.ref<!fir.box<!fir.heap<!fir.array<?xi32>>>>
! CHECK: omp.simd nontemporal(%[[X_DECL]] : !fir.ref<!fir.box<!fir.heap<!fir.array<?xi32>>>>) private(@_QFsimd_nontemporal_allocatableEi_private_i32 %2 -> %arg2 : !fir.ref<i32>) {
! CHECK: omp.loop_nest (%{{.*}}) : i32 = (%{{.*}}) to (%{{.*}}) inclusive step (%{{.*}}) {
!$omp simd nontemporal(x)
do i=1,100
! CHECK: %[[VAL1:.*]] = fir.load %[[X_DECL]] : !fir.ref<!fir.box<!fir.heap<!fir.array<?xi32>>>>
! CHECK: %[[BOX_ADDR:.*]] = fir.box_addr %[[VAL1]] : (!fir.box<!fir.heap<!fir.array<?xi32>>>) -> !fir.heap<!fir.array<?xi32>>
! CHECK: %[[ARR_COOR:.*]] = fir.array_coor %[[BOX_ADDR]](%{{.*}}) %{{.*}} : (!fir.heap<!fir.array<?xi32>>, !fir.shapeshift<1>, i64) -> !fir.ref<i32>
! CHECK: %[[VAL2:.*]] = fir.load %[[ARR_COOR]] {nontemporal} : !fir.ref<i32>
x(i) = x(i) + y
! CHECK: fir.store %{{.*}} to %{{.*}} {nontemporal} : !fir.ref<i32>
end do
!$omp end simd
end subroutine

! CHECK-LABEL: func.func @_QPsimd_nontemporal_pointers
subroutine simd_nontemporal_pointers(a, c)
integer :: b, i
integer :: n
integer, pointer, intent(in):: a(:)
integer, pointer, intent(out) :: c(:)
! CHECK: %[[A_DECL:.*]] = fir.declare %{{.*}} dummy_scope %{{.*}} {fortran_attrs = #fir.var_attrs<intent_in, pointer>,
! CHECK-SAME: uniq_name = "_QFsimd_nontemporal_pointersEa"} : (!fir.ref<!fir.box<!fir.ptr<!fir.array<?xi32>>>>, !fir.dscope) -> !fir.ref<!fir.box<!fir.ptr<!fir.array<?xi32>>>>
! CHECK: %[[C_DECL:.*]] = fir.declare %{{.*}} dummy_scope %{{.*}} {fortran_attrs = #fir.var_attrs<intent_out, pointer>,
! CHECK-SAME: uniq_name = "_QFsimd_nontemporal_pointersEc"} : (!fir.ref<!fir.box<!fir.ptr<!fir.array<?xi32>>>>, !fir.dscope) -> !fir.ref<!fir.box<!fir.ptr<!fir.array<?xi32>>>>
!$OMP SIMD NONTEMPORAL(a,c)
do i = 1, n
! CHECK: %[[VAL1:.*]] = fir.load %[[A_DECL]] : !fir.ref<!fir.box<!fir.ptr<!fir.array<?xi32>>>>
! CHECK: %[[VAL2:.*]] = fir.array_coor %[[VAL1]](%{{.*}}) %{{.*}} : (!fir.box<!fir.ptr<!fir.array<?xi32>>>, !fir.shift<1>, i64) -> !fir.ref<i32>
! CHECK: %[[VAL3:.*]] = fir.load %[[VAL2]] {nontemporal} : !fir.ref<i32>
c(i) = a(i) + b
! CHECK: %[[VAL4:.*]] = fir.load %[[C_DECL]] : !fir.ref<!fir.box<!fir.ptr<!fir.array<?xi32>>>>
! CHECK: %[[VAL5:.*]] = fir.array_coor %[[VAL4]](%{{.*}}) %{{.*}} : (!fir.box<!fir.ptr<!fir.array<?xi32>>>, !fir.shift<1>, i64) -> !fir.ref<i32>
! CHECK: fir.store %{{.*}} to %[[VAL5]] {nontemporal} : !fir.ref<i32>
end do
!$OMP END SIMD
end subroutine

Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,6 @@ static LogicalResult checkImplementationStatus(Operation &op) {
if (!op.getLinearVars().empty() || !op.getLinearStepVars().empty())
result = todo("linear");
};
auto checkNontemporal = [&todo](auto op, LogicalResult &result) {
if (!op.getNontemporalVars().empty())
result = todo("nontemporal");
};
auto checkNowait = [&todo](auto op, LogicalResult &result) {
if (op.getNowait())
result = todo("nowait");
Expand Down Expand Up @@ -296,7 +292,6 @@ static LogicalResult checkImplementationStatus(Operation &op) {
})
.Case([&](omp::SimdOp op) {
checkLinear(op, result);
checkNontemporal(op, result);
checkReduction(op, result);
})
.Case<omp::AtomicReadOp, omp::AtomicWriteOp, omp::AtomicUpdateOp,
Expand Down Expand Up @@ -2514,6 +2509,7 @@ convertOmpSimd(Operation &opInst, llvm::IRBuilderBase &builder,

llvm::MapVector<llvm::Value *, llvm::Value *> alignedVars;
llvm::omp::OrderKind order = convertOrderKind(simdOp.getOrder());

llvm::BasicBlock *sourceBlock = builder.GetInsertBlock();
std::optional<ArrayAttr> alignmentValues = simdOp.getAlignments();
mlir::OperandRange operands = simdOp.getAlignedVars();
Expand Down
96 changes: 96 additions & 0 deletions mlir/test/Target/LLVMIR/openmp-nontemporal.mlir
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
// RUN: mlir-translate -mlir-to-llvmir %s | FileCheck %s

// -----
// CHECK-LABEL: @simd_nontemporal
llvm.func @simd_nontemporal() {
%0 = llvm.mlir.constant(10 : i64) : i64
%1 = llvm.mlir.constant(1 : i64) : i64
%2 = llvm.alloca %1 x i64 : (i64) -> !llvm.ptr
%3 = llvm.alloca %1 x i64 : (i64) -> !llvm.ptr
//CHECK: %[[A_ADDR:.*]] = alloca i64, i64 1, align 8
//CHECK: %[[B_ADDR:.*]] = alloca i64, i64 1, align 8
//CHECK: %[[B:.*]] = load i64, ptr %[[B_ADDR]], align 4, !nontemporal !1, !llvm.access.group !2
//CHECK: store i64 %[[B]], ptr %[[A_ADDR]], align 4, !nontemporal !1, !llvm.access.group !2
omp.simd nontemporal(%2, %3 : !llvm.ptr, !llvm.ptr) {
omp.loop_nest (%arg0) : i64 = (%1) to (%0) inclusive step (%1) {
%4 = llvm.load %3 {nontemporal}: !llvm.ptr -> i64
llvm.store %4, %2 {nontemporal} : i64, !llvm.ptr
omp.yield
}
}
llvm.return
}

// -----

//CHECK-LABEL: define void @_QPtest(ptr %0, ptr %1) {
llvm.func @_QPtest(%arg0: !llvm.ptr {fir.bindc_name = "n"}, %arg1: !llvm.ptr {fir.bindc_name = "a"}) {
%0 = llvm.mlir.constant(1 : i32) : i32
%1 = llvm.alloca %0 x !llvm.struct<(ptr, i64, i32, i8, i8, i8, i8, array<1 x array<3 x i64>>)> {alignment = 8 : i64} : (i32) -> !llvm.ptr
%2 = llvm.alloca %0 x !llvm.struct<(ptr, i64, i32, i8, i8, i8, i8, array<1 x array<3 x i64>>)> {alignment = 8 : i64} : (i32) -> !llvm.ptr
%3 = llvm.mlir.constant(1 : i64) : i64
%4 = llvm.alloca %3 x i32 {bindc_name = "i", pinned} : (i64) -> !llvm.ptr
%6 = llvm.load %arg0 : !llvm.ptr -> i32
// CHECK: %[[A_VAL1:.*]] = alloca { ptr, i64, i32, i8, i8, i8, i8, [1 x [3 x i64]] }, align 8
// CHECK: %[[A_VAL2:.*]] = alloca { ptr, i64, i32, i8, i8, i8, i8, [1 x [3 x i64]] }, align 8
omp.simd nontemporal(%arg1 : !llvm.ptr) {
omp.loop_nest (%arg2) : i32 = (%0) to (%6) inclusive step (%0) {
llvm.store %arg2, %4 : i32, !llvm.ptr
// CHECK: call void @llvm.memcpy.p0.p0.i32(ptr %[[A_VAL2]], ptr %1, i32 48, i1 false)
%7 = llvm.mlir.constant(48 : i32) : i32
"llvm.intr.memcpy"(%2, %arg1, %7) <{isVolatile = false}> : (!llvm.ptr, !llvm.ptr, i32) -> ()
%8 = llvm.load %4 : !llvm.ptr -> i32
%9 = llvm.sext %8 : i32 to i64
%10 = llvm.getelementptr %2[0, 0] : (!llvm.ptr) -> !llvm.ptr, !llvm.struct<(ptr, i64, i32, i8, i8, i8, i8, array<1 x array<3 x i64>>)>
%11 = llvm.load %10 : !llvm.ptr -> !llvm.ptr
%12 = llvm.mlir.constant(0 : index) : i64
%13 = llvm.getelementptr %2[0, 7, %12, 0] : (!llvm.ptr, i64) -> !llvm.ptr, !llvm.struct<(ptr, i64, i32, i8, i8, i8, i8, array<1 x array<3 x i64>>)>
%14 = llvm.load %13 : !llvm.ptr -> i64
%15 = llvm.getelementptr %2[0, 7, %12, 1] : (!llvm.ptr, i64) -> !llvm.ptr, !llvm.struct<(ptr, i64, i32, i8, i8, i8, i8, array<1 x array<3 x i64>>)>
%16 = llvm.load %15 : !llvm.ptr -> i64
%17 = llvm.getelementptr %2[0, 7, %12, 2] : (!llvm.ptr, i64) -> !llvm.ptr, !llvm.struct<(ptr, i64, i32, i8, i8, i8, i8, array<1 x array<3 x i64>>)>
%18 = llvm.load %17 : !llvm.ptr -> i64
%19 = llvm.mlir.constant(0 : i64) : i64
%20 = llvm.sub %9, %14 overflow<nsw> : i64
%21 = llvm.mul %20, %3 overflow<nsw> : i64
%22 = llvm.mul %21, %3 overflow<nsw> : i64
%23 = llvm.add %22,%19 overflow<nsw> : i64
%24 = llvm.mul %3, %16 overflow<nsw> : i64
// CHECK: %[[VAL1:.*]] = getelementptr float, ptr {{.*}}, i64 %{{.*}}
// CHECK: %[[LOAD_A:.*]] = load float, ptr %[[VAL1]], align 4, !nontemporal
// CHECK: %[[RES:.*]] = fadd contract float %[[LOAD_A]], 2.000000e+01
%25 = llvm.getelementptr %11[%23] : (!llvm.ptr, i64) -> !llvm.ptr, f32
%26 = llvm.load %25 {nontemporal} : !llvm.ptr -> f32
%27 = llvm.mlir.constant(2.000000e+01 : f32) : f32
%28 = llvm.fadd %26, %27 {fastmathFlags = #llvm.fastmath<contract>} : f32
// CHECK: call void @llvm.memcpy.p0.p0.i32(ptr %[[A_VAL1]], ptr %1, i32 48, i1 false)
%29 = llvm.mlir.constant(48 : i32) : i32
"llvm.intr.memcpy"(%1, %arg1, %29) <{isVolatile = false}> : (!llvm.ptr, !llvm.ptr, i32) -> ()
%30 = llvm.load %4 : !llvm.ptr -> i32
%31 = llvm.sext %30 : i32 to i64
%32 = llvm.getelementptr %1[0, 0] : (!llvm.ptr) -> !llvm.ptr, !llvm.struct<(ptr, i64, i32, i8, i8, i8, i8, array<1 x array<3 x i64>>)>
%33 = llvm.load %32 : !llvm.ptr -> !llvm.ptr
%34 = llvm.mlir.constant(0 : index) : i64
%35 = llvm.getelementptr %1[0, 7, %34, 0] : (!llvm.ptr, i64) -> !llvm.ptr, !llvm.struct<(ptr, i64, i32, i8, i8, i8, i8, array<1 x array<3 x i64>>)>
%36 = llvm.load %35 : !llvm.ptr -> i64
%37 = llvm.getelementptr %1[0, 7, %34, 1] : (!llvm.ptr, i64) -> !llvm.ptr, !llvm.struct<(ptr, i64, i32, i8, i8, i8, i8, array<1 x array<3 x i64>>)>
%38 = llvm.load %37 : !llvm.ptr -> i64
%39 = llvm.getelementptr %1[0, 7, %34, 2] : (!llvm.ptr, i64) -> !llvm.ptr, !llvm.struct<(ptr, i64, i32, i8, i8, i8, i8, array<1 x array<3 x i64>>)>
%40 = llvm.load %39 : !llvm.ptr -> i64
%41 = llvm.sub %31, %36 overflow<nsw> : i64
%42 = llvm.mul %41, %3 overflow<nsw> : i64
%43 = llvm.mul %42, %3 overflow<nsw> : i64
%44 = llvm.add %43,%19 overflow<nsw> : i64
%45 = llvm.mul %3, %38 overflow<nsw> : i64
// CHECK: %[[VAL2:.*]] = getelementptr float, ptr %{{.*}}, i64 %{{.*}}
// CHECK: store float %[[RES]], ptr %[[VAL2]], align 4, !nontemporal
%46 = llvm.getelementptr %33[%44] : (!llvm.ptr, i64) -> !llvm.ptr, f32
llvm.store %28, %46 {nontemporal} : f32, !llvm.ptr
omp.yield
}
}
llvm.return
}

// -----

13 changes: 0 additions & 13 deletions mlir/test/Target/LLVMIR/openmp-todo.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -169,19 +169,6 @@ llvm.func @simd_linear(%lb : i32, %ub : i32, %step : i32, %x : !llvm.ptr) {

// -----

llvm.func @simd_nontemporal(%lb : i32, %ub : i32, %step : i32, %x : !llvm.ptr) {
// expected-error@below {{not yet implemented: Unhandled clause nontemporal in omp.simd operation}}
// expected-error@below {{LLVM Translation failed for operation: omp.simd}}
omp.simd nontemporal(%x : !llvm.ptr) {
omp.loop_nest (%iv) : i32 = (%lb) to (%ub) step (%step) {
omp.yield
}
}
llvm.return
}

// -----

omp.declare_reduction @add_f32 : f32
init {
^bb0(%arg: f32):
Expand Down