-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[libc] add headers.txt for windows #118675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@SchrodingerZhu if you have a windows build handy, can you please help test this out? This would be doing a fullbuild on windows. |
@llvm/pr-subscribers-libc Author: Nick Desaulniers (nickdesaulniers) ChangesLink: #117220 (comment) Full diff: https://github.com/llvm/llvm-project/pull/118675.diff 1 Files Affected:
diff --git a/libc/config/windows/headers.txt b/libc/config/windows/headers.txt
new file mode 100644
index 00000000000000..d5b44fc07277e5
--- /dev/null
+++ b/libc/config/windows/headers.txt
@@ -0,0 +1,32 @@
+set(TARGET_PUBLIC_HEADERS
+ libc.include.assert
+ libc.include.ctype
+ libc.include.dirent
+ libc.include.errno
+ libc.include.features
+ libc.include.fenv
+ libc.include.float
+ libc.include.inttypes
+ libc.include.limits
+ libc.include.link
+ libc.include.locale
+ libc.include.malloc
+ libc.include.math
+ libc.include.sched
+ libc.include.search
+ libc.include.setjmp
+ libc.include.signal
+ libc.include.stdbit
+ libc.include.stdckdint
+ libc.include.stdfix
+ libc.include.stdint
+ libc.include.stdio
+ libc.include.stdlib
+ libc.include.string
+ libc.include.strings
+ libc.include.threads
+ libc.include.time
+ libc.include.uchar
+ libc.include.unistd
+ libc.include.wchar
+)
|
trying out now on windows server 2025. |
No issue found running |
I also kicked off https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/clang-windows-x64/b8729459123378281649/overview with this patch. |
Co-authored-by: Michael Jones <michaelrj@google.com>
Looks like that passed to me, but its also my first time looking at that such dashboard. |
Link: #117220 (comment)