Skip to content

[Github] fix libc documentation path #118514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

nickdesaulniers
Copy link
Member

@nickdesaulniers nickdesaulniers commented Dec 3, 2024

Running ninja docs-libc-html produces content in {build_dir}/libc/docs, not
{build_dir}/docs. Presubmit jobs for "Test documentation build" were failing as
a result of commit 97f94af ("[Github] Upload built docs as artifact from
test build docs job (#118159)")

Link: #118159
Link: #117220

Running `ninja docs-libc-html` produces content in {build_dir}/libc/docs, not
{build_dir}/docs. Presubmit jobs for "Test documentation build" were failing as
a result of commit 97f94af ("[Github] Upload built docs as artifact from
test build docs job (llvm#118159)")
@llvmbot
Copy link
Member

llvmbot commented Dec 3, 2024

@llvm/pr-subscribers-github-workflow

Author: Nick Desaulniers (nickdesaulniers)

Changes

Running ninja docs-libc-html produces content in {build_dir}/libc/docs, not
{build_dir}/docs. Presubmit jobs for "Test documentation build" were failing as
a result of commit 97f94af ("[Github] Upload built docs as artifact from
test build docs job (#118159)")


Full diff: https://github.com/llvm/llvm-project/pull/118514.diff

1 Files Affected:

  • (modified) .github/workflows/docs.yml (+1-1)
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 2e4009994a2b0d..fe9c70cf1f5a95 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -162,7 +162,7 @@ jobs:
           cmake -B libc-build -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_RUNTIMES="libc" -DLLVM_ENABLE_SPHINX=ON ./runtimes
           TZ=UTC ninja -C libc-build docs-libc-html
           mkdir built-docs/libc
-          cp -r libc-build/docs/* built-docs/libc/
+          cp -r libc-build/libc/docs/* built-docs/libc/
       - name: Build LLD docs
         if: steps.docs-changed-subprojects.outputs.lld_any_changed == 'true'
         run: |

@nickdesaulniers
Copy link
Member Author

I'm not sure if this issue is more pervasive than just libc, or if we should perhaps change something about how we build the libc docs (where they wind up in the build dir)?

@nickdesaulniers nickdesaulniers merged commit ce416a0 into llvm:main Dec 3, 2024
9 checks passed
@nickdesaulniers nickdesaulniers deleted the presubmit_docs branch December 3, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants