Skip to content

[libc] disable process_mrelease for riscv #117956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

SchrodingerZhu
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu commented Nov 28, 2024

process_mrelease upsets the RV32 build bot. Disable it for now.

@llvmbot llvmbot added the libc label Nov 28, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 28, 2024

@llvm/pr-subscribers-libc

Author: Schrodinger ZHU Yifan (SchrodingerZhu)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/117956.diff

1 Files Affected:

  • (modified) libc/config/linux/riscv/entrypoints.txt (+2-1)
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 4ea65f76d7948d..3baf734d3d8197 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -251,7 +251,8 @@ set(TARGET_LIBC_ENTRYPOINTS
     libc.src.sys.mman.munmap
     libc.src.sys.mman.remap_file_pages
     libc.src.sys.mman.posix_madvise
-    libc.src.sys.mman.process_mrelease
+    # TODO: disabled due to buildbot failure. further investigation needed.
+    # libc.src.sys.mman.process_mrelease
     libc.src.sys.mman.shm_open
     libc.src.sys.mman.shm_unlink
 

@SchrodingerZhu
Copy link
Contributor Author

merge as a quick fix attempt for CI.

@SchrodingerZhu SchrodingerZhu merged commit 700d9ac into llvm:main Nov 28, 2024
7 of 9 checks passed
@SchrodingerZhu SchrodingerZhu deleted the libc/mrelease-fix2 branch November 28, 2024 02:17
@nickdesaulniers
Copy link
Member

Now that #118049 has landed, should this get reverted?

SchrodingerZhu added a commit to SchrodingerZhu/llvm-project that referenced this pull request Dec 4, 2024
SchrodingerZhu added a commit to SchrodingerZhu/llvm-project that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants