Skip to content

[clang][www] Remove ClangDataFormat.py from docs #117943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

emaxx-google
Copy link
Contributor

The script was removed in #96385.

Instead, mention the LLVM formatter as it's still very useful for Clang's code.

The script was removed in llvm#96385.

Instead, mention the LLVM formatter as it's still very useful for Clang's code.
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Nov 27, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 27, 2024

@llvm/pr-subscribers-clang

Author: Maksim Ivanov (emaxx-google)

Changes

The script was removed in #96385.

Instead, mention the LLVM formatter as it's still very useful for Clang's code.


Full diff: https://github.com/llvm/llvm-project/pull/117943.diff

1 Files Affected:

  • (modified) clang/www/hacking.html (+3-3)
diff --git a/clang/www/hacking.html b/clang/www/hacking.html
index 78b67cd05c53c6..a17e791eed477a 100755
--- a/clang/www/hacking.html
+++ b/clang/www/hacking.html
@@ -89,9 +89,9 @@ <h2 id="debugging">Debugging</h2>
       qualifiers, and the <tt>getTypePtr()</tt> method to get the
       wrapped <tt>Type*</tt> which you can then dump.</li>
       <li>For <a href="https://lldb.llvm.org"> <tt>LLDB</tt></a> users there are
-      data formatters for clang data structures in
-      <a href="/llvm/llvm-project/blob/main/clang/utils/ClangDataFormat.py">
-      <tt>clang/utils/ClangDataFormat.py</tt></a>.</li>
+      data formatters for LLVM data structures in
+      <a href="/llvm/llvm-project/blob/main/llvm/utils/lldbDataFormatters.py">
+      <tt>llvm/utils/lldbDataFormatters.py</tt></a>.</li>
     </ul>
 
   <!--=====================================================================-->

@emaxx-google
Copy link
Contributor Author

@Michael137

Copy link
Member

@Michael137 Michael137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how well maintained these are either, but since they still exist, LGTM

@Michael137 Michael137 merged commit 026fbe5 into llvm:main Dec 4, 2024
10 checks passed
Copy link

github-actions bot commented Dec 4, 2024

@emaxx-google Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@emaxx-google
Copy link
Contributor Author

Thanks for the review and for the merge!

Not sure how well maintained these are either, but since they still exist, LGTM

If you mean the lldbDataFormatters.py script, then I don't know either, but at least when I tried it it turned out to be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants