[DebugInfo] Add DW_AT_artificial for compiler generated static member. #116327
Conversation
Consider the case when the compiler generates a static member. Any consumer of the debug info generated for that case, would benefit if that member has the DW_AT_artificial flag. Fix buildbot failure on: llvm-clang-aarch64-darwin - Add specific configuration: x86_64-linux
CarlosAlbertoEnciso
requested review from
jmorse,
SLTozer,
OCHyams,
dwblaikie and
pogo59
|
@llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-llvm-binary-utilities Author: Carlos Alberto Enciso (CarlosAlbertoEnciso) ChangesConsider the case when the compiler generates a static member. Any consumer of the debug info generated for that case, would benefit if that member has the DW_AT_artificial flag. Fix buildbot failure on: llvm-clang-aarch64-darwin
Full diff: https://github.com/llvm/llvm-project/pull/116327.diff 1 Files Affected:
diff --git a/llvm/test/DebugInfo/Generic/artificial-static-member.ll b/llvm/test/DebugInfo/Generic/artificial-static-member.ll
index 3263c976e39158..5c247d6959bf7b 100644
--- a/llvm/test/DebugInfo/Generic/artificial-static-member.ll
+++ b/llvm/test/DebugInfo/Generic/artificial-static-member.ll
@@ -1,3 +1,4 @@
+; REQUIRES: x86_64-linux
; RUN: llc -O0 -filetype=obj < %s | \
; RUN: llvm-dwarfdump --debug-info - | FileCheck %s
|
| ; REQUIRES: x86_64-linux | ||
| ; RUN: llc -O0 -filetype=obj < %s | \ |
There was a problem hiding this comment.
The requirement will never be satisfied; the test will never run. You need a regular expression of the form target={{x86_64-.*-linux}} here.
But, it's probably better to remove the target triple clause from the IR, and add -triple=%itanium_target_triple to the llc command. Then you won't need a REQUIRES clause at all.
There was a problem hiding this comment.
@pogo59 Thanks very much for your feedback.
I tried your second suggestion: -triple=%itanium_target_triple but llc raises the following error:
Unknown command line argument '-triple=%itanium_target_triple'.
llc: Did you mean '--mtriple=%itanium_target_triple'?
I looked at other test cases and it seems that it is valid only for clang:
// RUN: %clang_cc1 -triple %itanium_abi_triple ....
Created a new PR using the REQUIRES with a regular expression: #116429
dwblaikie
added
the
skip-precommit-approval
|
If you're using a PR only for presubmit checks, not for pre-commit review, please apply the |
@dwblaikie Thanks very much. |
llvm#116327) Consider the case when the compiler generates a static member. Any consumer of the debug info generated for that case, would benefit if that member has the DW_AT_artificial flag. Fix the syntax for 'REQUIRES', to include a regular expression.
Include a regular expression in the 'REQUIRES' clause, to run the test on all matching targets (x86_64 *linux*). The original patch restricted to test just to 'x86_64-linux' llvm#116327
Include a regular expression in the 'REQUIRES' clause, to run the test on all matching targets (x86_64 *linux*). The original patch restricted to test just to 'x86_64-linux' #116327
CarlosAlbertoEnciso
deleted the
artificial-static-member-fix-failing-test
branch
Consider the case when the compiler generates a static member. Any consumer of the debug info generated for that case, would benefit if that member has the DW_AT_artificial flag.
Fix buildbot failure on: llvm-clang-aarch64-darwin