Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libclc] Create aliases with custom_command #115885

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

frasercrmck
Copy link
Contributor

This in conjunction with a custom target prevents them from being rebuilt if there are no changes.

This in conjunction with a custom target prevents them from being
rebuilt if there are no changes.
@frasercrmck frasercrmck added the libclc libclc OpenCL library label Nov 12, 2024
@frasercrmck frasercrmck requested a review from arsenm November 12, 2024 15:44
@arsenm arsenm added the cmake Build system in general and CMake in particular label Nov 12, 2024
@frasercrmck frasercrmck merged commit 584d1a6 into llvm:main Nov 12, 2024
11 checks passed
@frasercrmck frasercrmck deleted the libclc-clc-aliases branch November 12, 2024 17:22
@mgorny
Copy link
Member

mgorny commented Nov 13, 2024

This change broke installing for us, see bug #115942.

sylvestre added a commit that referenced this pull request Nov 13, 2024
@sylvestre
Copy link
Collaborator

I reverted it in 2c98031

frasercrmck added a commit to frasercrmck/llvm-project that referenced this pull request Nov 13, 2024
frasercrmck added a commit that referenced this pull request Nov 13, 2024
@frasercrmck
Copy link
Contributor Author

Relanded in #116025.

akshayrdeodhar pushed a commit to akshayrdeodhar/llvm-project that referenced this pull request Nov 18, 2024
akshayrdeodhar pushed a commit to akshayrdeodhar/llvm-project that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular libclc libclc OpenCL library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants