[CAS] Add UnifiedOnDiskCache and OnDiskCAS #114103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2024
Add OnDiskCAS abstraction, that implements ObjectStore and ActionCache interface using OnDiskGraphDB and OnDiskKeyValueDB. Reviewers: Pull Request: #114103
cachemeifyoucan
changed the base branch from
users/cachemeifyoucan/spr/main.cas-add-ondiskcas
to
main
cachemeifyoucan
force-pushed
the
users/cachemeifyoucan/spr/cas-add-ondiskcas
branch
from
94172a6 to
4b951ef
Compare
cachemeifyoucan
changed the title
Created using spr 1.3.7
Created using spr 1.3.7
bogner
reviewed
Oct 28, 2025
| Error validate() const final; | ||
|
|
||
| private: | ||
| std::shared_ptr<ondisk::UnifiedOnDiskCache> UniDB; |
There was a problem hiding this comment.
Maybe I'm missing it, but why does this need to be a shared_ptr? I don't see obvious uses where we're really relying on the refcount here.
There was a problem hiding this comment.
This is just extending the lifetime of the wrapped UnifiedOnDiskCache to make sure it is not deleted when ActionCache is still in use.
Alternatively, we can leave this as a raw pointer and left the life-time management to user, but since this is not really a ref-count that is being updated often, this safe guard is pretty safe to keep.
Created using spr 1.3.7
bogner
approved these changes
Oct 30, 2025
adrian-prantl
approved these changes
Oct 31, 2025
ilovepi
approved these changes
Nov 1, 2025
Created using spr 1.3.7
cachemeifyoucan
deleted the
users/cachemeifyoucan/spr/cas-add-ondiskcas
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new abstraction layer UnifiedOnDiskCache that adds new functions
of disk space management and data validation that builds on top of
OnDiskGraphDB and OnDiskKeyValueDB.
Build upon UnifiedOnDiskCache, it is OnDiskCAS that implements
ObjectStore and ActionCache interface for LLVM tools to interact with
CAS storage.