Skip to content

[libc] Fix compilation of new trig functions #111987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2024
Merged

[libc] Fix compilation of new trig functions #111987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2e0a33
[libc] Fix compilation of new trig functions
jhuber6 Oct 11, 2024
5ddf840
comments
jhuber6 Oct 11, 2024
7ccd943
comments
jhuber6 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libc/src/math/generic/cos.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ LLVM_LIBC_FUNCTION(double, cos, (double x)) {
}
return ans;
};
DoubleDouble sin_k = get_idx_dd(k + 128);
DoubleDouble msin_k = get_idx_dd(k + 128);
DoubleDouble cos_k = get_idx_dd(k + 64);
#else
// Fast look up version, but needs 256-entry table.
Expand Down
2 changes: 1 addition & 1 deletion libc/src/math/generic/range_reduction_double_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ struct LargeRangeReduction {
DoubleDouble y_mid;
};

#ifndef LIBC_MATH_HAS_SKIP_ACCURATE_PASS
static Float128 range_reduction_small_f128(double x) {
constexpr Float128 PI_OVER_128_F128 = {
Sign::POS, -133, 0xc90f'daa2'2168'c234'c4c6'628b'80dc'1cd1_u128};
Expand All @@ -300,7 +301,6 @@ static Float128 range_reduction_small_f128(double x) {
return fputil::quick_mul(y, PI_OVER_128_F128);
}

#ifndef LIBC_MATH_HAS_SKIP_ACCURATE_PASS
static constexpr Float128 SIN_K_PI_OVER_128_F128[65] = {
{Sign::POS, 0, 0},
{Sign::POS, -133, 0xc90a'afbd'1b33'efc9'c539'edcb'fda0'cf2c_u128},
Expand Down
Loading