[SandboxIR] Implement getNumBits for Instructions #110748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vporpo
reviewed
Oct 1, 2024
Contributor
vporpo
left a comment
vporpo
left a comment
There was a problem hiding this comment.
Btw. please also move the remaining utils test to UtilsTest.cpp in a separate PR.
|
|
||
| // getNumBits for scalars via the Instruction overload | ||
| EXPECT_EQ( | ||
| sandboxir::Utils::getNumBits(cast<sandboxir::Instruction>(F->getArg(0))), |
Contributor
There was a problem hiding this comment.
This should trigger an assertion because F->getArg(0) is not a sandboxir::Instruction.
Contributor
Author
There was a problem hiding this comment.
I had been running the SandboxVectorizerTests, not the SandboxIR tests.
Fixed.
Sterling-Augustine
added a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
This also moves the other getNumbits test into UtilsTest.cc where it belongs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves the other getNumbits test into UtilsTest.cc where it belongs.