[SystemZ][z/OS] fix sample-split-layout.test on z/OS #109679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-pgo Author: Zibi Sarbinowski (zibi2) ChangesThe Lit in subject fails on z/OS since the input file This PR removes the diff command which fails because it compares a binary file and a text file. The rational is that this diff command seems to be redundant to the Full diff: https://github.com/llvm/llvm-project/pull/109679.diff 1 Files Affected:
diff --git a/llvm/test/tools/llvm-profdata/sample-split-layout.test b/llvm/test/tools/llvm-profdata/sample-split-layout.test
index a1927c80b2e29b..51091e9f25c02d 100644
--- a/llvm/test/tools/llvm-profdata/sample-split-layout.test
+++ b/llvm/test/tools/llvm-profdata/sample-split-layout.test
@@ -1,5 +1,4 @@
RUN: llvm-profdata merge --sample --extbinary --split-layout %p/Inputs/sample-profile.proftext -o %t-output
-RUN: diff %t-output %p/Inputs/split-layout.profdata
RUN: llvm-profdata merge --sample --text --split-layout %t-output | FileCheck %s
CHECK: main:184019:0
|
|
ping |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/70/builds/3729 Here is the relevant piece of the build log for the reference |
s-perron
pushed a commit
to s-perron/llvm-project
that referenced
this pull request
Oct 8, 2024
The Lit in subject fails on z/OS since the input file `Inputs/split-layout.profdata` is marked as ASCII even though it is binary and the output file `Output/sample-split-layout.test.tmp-output` is binary. This PR removes the diff command which fails because it compares a binary file and a text file. The rational is that this diff command seems to be redundant to the `FileCheck` on the next command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Lit in subject fails on z/OS since the input file
Inputs/split-layout.profdatais marked as ASCII even though it is binary and the output fileOutput/sample-split-layout.test.tmp-outputis binary.This PR removes the diff command which fails because it compares a binary file and a text file. The rational is that this diff command seems to be redundant to the
FileCheckon the next command.