Reland [MLIR] Make resolveCallable customizable in CallOpInterface #107989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
mlir:core
|
@llvm/pr-subscribers-mlir-bufferization @llvm/pr-subscribers-mlir Author: Henrich Lauko (xlauko) ChangesFull diff: https://github.com/llvm/llvm-project/pull/107989.diff 3 Files Affected:
diff --git a/mlir/lib/Dialect/Async/IR/CMakeLists.txt b/mlir/lib/Dialect/Async/IR/CMakeLists.txt
index db903a48c43196..e0e667500308ae 100644
--- a/mlir/lib/Dialect/Async/IR/CMakeLists.txt
+++ b/mlir/lib/Dialect/Async/IR/CMakeLists.txt
@@ -8,6 +8,7 @@ add_mlir_dialect_library(MLIRAsyncDialect
MLIRAsyncOpsIncGen
LINK_LIBS PUBLIC
+ MLIRCallInterfaces
MLIRControlFlowInterfaces
MLIRFunctionInterfaces
MLIRDialect
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/CMakeLists.txt b/mlir/lib/Dialect/Bufferization/Transforms/CMakeLists.txt
index f27d924416677a..50104e8f8346b4 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/CMakeLists.txt
+++ b/mlir/lib/Dialect/Bufferization/Transforms/CMakeLists.txt
@@ -27,6 +27,7 @@ add_mlir_dialect_library(MLIRBufferizationTransforms
LINK_LIBS PUBLIC
MLIRArithDialect
MLIRBufferizationDialect
+ MLIRCallInterfaces
MLIRControlFlowInterfaces
MLIRFuncDialect
MLIRFunctionInterfaces
@@ -42,4 +43,3 @@ add_mlir_dialect_library(MLIRBufferizationTransforms
MLIRViewLikeInterface
MLIRSupport
)
-
diff --git a/mlir/lib/Transforms/Utils/CMakeLists.txt b/mlir/lib/Transforms/Utils/CMakeLists.txt
index b5788c679edc44..eb588640dbf83a 100644
--- a/mlir/lib/Transforms/Utils/CMakeLists.txt
+++ b/mlir/lib/Transforms/Utils/CMakeLists.txt
@@ -16,6 +16,7 @@ add_mlir_library(MLIRTransformUtils
LINK_LIBS PUBLIC
MLIRAnalysis
+ MLIRCallInterfaces
MLIRControlFlowInterfaces
MLIRFunctionInterfaces
MLIRLoopLikeInterface
|
|
Why are these needed? In which situation do they fail? Is this a non-deterministic build failure? (if so can you post the error message). |
|
Is this a follow-up to #100361 ? If so it has been reverted and you can incorporate these fixes when you reland it. Thanks! (if a bot is broken: we need to either land such fix immediately or revert in the meantime to unbreak the CI) |
|
@joker-eph yes, this was follow-up to #100361 |
|
The original commit, with the fixes :) |
xlauko
changed the title
MLIRCallInterfaces dependency to libraries.
xlauko
changed the title
xlauko
force-pushed
the
main
branch
2 times, most recently
from
657fe4e to
67383ff
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
llvm#100361) Allow customization of the `resolveCallable` method in the `CallOpInterface`. This change allows for operations implementing this interface to provide their own logic for resolving callables. - Introduce the `resolveCallable` method, which does not include the optional symbol table parameter. This method replaces the previously existing extra class declaration `resolveCallable`. - Introduce the `resolveCallableInTable` method, which incorporates the symbol table parameter. This method replaces the previous extra class declaration `resolveCallable` that used the optional symbol table parameter.
matthias-springer
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #100361 with fixed dependencies.