[TableGen] Resolve arguments with fields in records #107829
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, instantiating an anonymous record happened in two steps:
MapResolver
RecordResolver
.In 1, the
MapResolver
cannot resolve references to fields and in 2 theRecordResolver
cannot resolve references to arguments. This was leading to incomplete resolution inllvm/test/TableGen/record-recursion.td
(simplified test-case from #91050 ) like so:MapResolver
fails to resolve theif
condition since it references the fieldv
.SumTillN<!sub(n, 1)>.ret)
fails as it references the argumentn
and theRecordResolver
doesn't know about it.This patch merges the two steps into one where arguments and fields are resolved by the
RecordResolver
itself.