[mlir] Avoid repeated hash lookups (NFC) #107519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-core Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/107519.diff 1 Files Affected:
diff --git a/mlir/lib/IR/AttrTypeSubElements.cpp b/mlir/lib/IR/AttrTypeSubElements.cpp
index 783236ed3a9df6..863e1aa95f2fb7 100644
--- a/mlir/lib/IR/AttrTypeSubElements.cpp
+++ b/mlir/lib/IR/AttrTypeSubElements.cpp
@@ -27,10 +27,10 @@ WalkResult AttrTypeWalker::walkImpl(T element, WalkFns &walkFns,
WalkOrder order) {
// Check if we've already walk this element before.
auto key = std::make_pair(element.getAsOpaquePointer(), (int)order);
- auto it = visitedAttrTypes.find(key);
- if (it != visitedAttrTypes.end())
+ auto [it, inserted] =
+ visitedAttrTypes.try_emplace(key, WalkResult::advance());
+ if (!inserted)
return it->second;
- visitedAttrTypes.try_emplace(key, WalkResult::advance());
// If we are walking in post order, walk the sub elements first.
if (order == WalkOrder::PostOrder) {
|
|
@llvm/pr-subscribers-mlir Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/107519.diff 1 Files Affected:
diff --git a/mlir/lib/IR/AttrTypeSubElements.cpp b/mlir/lib/IR/AttrTypeSubElements.cpp
index 783236ed3a9df6..863e1aa95f2fb7 100644
--- a/mlir/lib/IR/AttrTypeSubElements.cpp
+++ b/mlir/lib/IR/AttrTypeSubElements.cpp
@@ -27,10 +27,10 @@ WalkResult AttrTypeWalker::walkImpl(T element, WalkFns &walkFns,
WalkOrder order) {
// Check if we've already walk this element before.
auto key = std::make_pair(element.getAsOpaquePointer(), (int)order);
- auto it = visitedAttrTypes.find(key);
- if (it != visitedAttrTypes.end())
+ auto [it, inserted] =
+ visitedAttrTypes.try_emplace(key, WalkResult::advance());
+ if (!inserted)
return it->second;
- visitedAttrTypes.try_emplace(key, WalkResult::advance());
// If we are walking in post order, walk the sub elements first.
if (order == WalkOrder::PostOrder) {
|
River707
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.