[Clang][NFC] Don't manually enumerate the PredefinedDeclIDs #106891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
cor3ntin
approved these changes
Sep 1, 2024
philnik777
deleted the
users/philnik777/remove_predefined_decl_ids_values
branch
|
@llvm/pr-subscribers-clang Author: Nikolas Klauser (philnik777) ChangesThis doesn't seem to have any use other than the possibility of merge conflicts and accidentally forgetting to update Full diff: https://github.com/llvm/llvm-project/pull/106891.diff 1 Files Affected:
diff --git a/clang/include/clang/AST/DeclID.h b/clang/include/clang/AST/DeclID.h
index e5e27389fac60d..81454a247229f5 100644
--- a/clang/include/clang/AST/DeclID.h
+++ b/clang/include/clang/AST/DeclID.h
@@ -20,8 +20,6 @@
#include "llvm/ADT/Hashing.h"
#include "llvm/ADT/iterator.h"
-#include <climits>
-
namespace clang {
/// Predefined declaration IDs.
@@ -32,65 +30,62 @@ namespace clang {
/// it is created.
enum PredefinedDeclIDs {
/// The NULL declaration.
- PREDEF_DECL_NULL_ID = 0,
+ PREDEF_DECL_NULL_ID,
/// The translation unit.
- PREDEF_DECL_TRANSLATION_UNIT_ID = 1,
+ PREDEF_DECL_TRANSLATION_UNIT_ID,
/// The Objective-C 'id' type.
- PREDEF_DECL_OBJC_ID_ID = 2,
+ PREDEF_DECL_OBJC_ID_ID,
/// The Objective-C 'SEL' type.
- PREDEF_DECL_OBJC_SEL_ID = 3,
+ PREDEF_DECL_OBJC_SEL_ID,
/// The Objective-C 'Class' type.
- PREDEF_DECL_OBJC_CLASS_ID = 4,
+ PREDEF_DECL_OBJC_CLASS_ID,
/// The Objective-C 'Protocol' type.
- PREDEF_DECL_OBJC_PROTOCOL_ID = 5,
+ PREDEF_DECL_OBJC_PROTOCOL_ID,
/// The signed 128-bit integer type.
- PREDEF_DECL_INT_128_ID = 6,
+ PREDEF_DECL_INT_128_ID,
/// The unsigned 128-bit integer type.
- PREDEF_DECL_UNSIGNED_INT_128_ID = 7,
+ PREDEF_DECL_UNSIGNED_INT_128_ID,
/// The internal 'instancetype' typedef.
- PREDEF_DECL_OBJC_INSTANCETYPE_ID = 8,
+ PREDEF_DECL_OBJC_INSTANCETYPE_ID,
/// The internal '__builtin_va_list' typedef.
- PREDEF_DECL_BUILTIN_VA_LIST_ID = 9,
+ PREDEF_DECL_BUILTIN_VA_LIST_ID,
/// The internal '__va_list_tag' struct, if any.
- PREDEF_DECL_VA_LIST_TAG = 10,
+ PREDEF_DECL_VA_LIST_TAG,
/// The internal '__builtin_ms_va_list' typedef.
- PREDEF_DECL_BUILTIN_MS_VA_LIST_ID = 11,
+ PREDEF_DECL_BUILTIN_MS_VA_LIST_ID,
/// The predeclared '_GUID' struct.
- PREDEF_DECL_BUILTIN_MS_GUID_ID = 12,
+ PREDEF_DECL_BUILTIN_MS_GUID_ID,
/// The extern "C" context.
- PREDEF_DECL_EXTERN_C_CONTEXT_ID = 13,
+ PREDEF_DECL_EXTERN_C_CONTEXT_ID,
/// The internal '__make_integer_seq' template.
- PREDEF_DECL_MAKE_INTEGER_SEQ_ID = 14,
+ PREDEF_DECL_MAKE_INTEGER_SEQ_ID,
/// The internal '__NSConstantString' typedef.
- PREDEF_DECL_CF_CONSTANT_STRING_ID = 15,
+ PREDEF_DECL_CF_CONSTANT_STRING_ID,
/// The internal '__NSConstantString' tag type.
- PREDEF_DECL_CF_CONSTANT_STRING_TAG_ID = 16,
+ PREDEF_DECL_CF_CONSTANT_STRING_TAG_ID,
/// The internal '__type_pack_element' template.
- PREDEF_DECL_TYPE_PACK_ELEMENT_ID = 17,
-};
+ PREDEF_DECL_TYPE_PACK_ELEMENT_ID,
-/// The number of declaration IDs that are predefined.
-///
-/// For more information about predefined declarations, see the
-/// \c PredefinedDeclIDs type and the PREDEF_DECL_*_ID constants.
-const unsigned int NUM_PREDEF_DECL_IDS = 18;
+ /// The number of declaration IDs that are predefined.
+ NUM_PREDEF_DECL_IDS
+};
/// GlobalDeclID means DeclID in the current ASTContext and LocalDeclID means
/// DeclID specific to a certain ModuleFile. Specially, in ASTWriter, the
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/2844 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/3339 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/1930 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/3210 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/2806 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't seem to have any use other than the possibility of merge conflicts and accidentally forgetting to update
NUM_PREDEF_DECL_IDS.