Restrict LLVM_TARGETS_TO_BUILD in Windows release packaging #106059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When including all targets, some files become too large for the NSIS installer to handle. Fixes llvm#101994
|
Ping @omjavaid |
|
/cherry-pick 2a28df6 |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 29, 2024
) When including all targets, some files become too large for the NSIS installer to handle. Fixes llvm#101994 (cherry picked from commit 2a28df6)
|
Failed to create pull request for issue106059 https://github.com/llvm/llvm-project/actions/runs/10614517531 |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 29, 2024
) When including all targets, some files become too large for the NSIS installer to handle. Fixes llvm#101994 (cherry picked from commit 2a28df6)
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Sep 1, 2024
) When including all targets, some files become too large for the NSIS installer to handle. Fixes llvm#101994 (cherry picked from commit 2a28df6)
zmodem
added a commit
to zmodem/llvm-project
that referenced
this pull request
Sep 9, 2024
LLVM_TARGETS_TO_BUILD was set in llvm#106059
tru
pushed a commit
to zmodem/llvm-project
that referenced
this pull request
Sep 10, 2024
LLVM_TARGETS_TO_BUILD was set in llvm#106059
zmodem
added a commit
to zmodem/llvm-project
that referenced
this pull request
Feb 19, 2025
In llvm#106059 we reduced the targets to those supported by Windows (X86 and ARM) to avoid running into size limitations of the NSIS compiler. Since then, people complained about the lack of Wasm [1], RISC-V [2], and BPF [3]. These do seem to fit in the installer (at least for 20.1.0-rc2), so let's add them back. [1] https://discourse.llvm.org/t/llvm-19-x-release-third-party-binaries/80374/26 [2] https://discourse.llvm.org/t/llvm-19-x-release-third-party-binaries/80374/53 [3] llvm#127120
zmodem
added a commit
that referenced
this pull request
Feb 20, 2025
…aging (#127794) In #106059 we reduced the targets to those supported by Windows (X86 and ARM) to avoid running into size limitations of the NSIS compiler. Since then, people complained about the lack of Wasm [1], RISC-V [2], BPF [3], and NVPTX [4]. These do seem to fit in the installer (at least for 20.1.0-rc2), so let's add them back. [1] https://discourse.llvm.org/t/llvm-19-x-release-third-party-binaries/80374/26 [2] https://discourse.llvm.org/t/llvm-19-x-release-third-party-binaries/80374/53 [3] #127120 [4] #127794 (comment)
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Feb 21, 2025
…aging (llvm#127794) In llvm#106059 we reduced the targets to those supported by Windows (X86 and ARM) to avoid running into size limitations of the NSIS compiler. Since then, people complained about the lack of Wasm [1], RISC-V [2], BPF [3], and NVPTX [4]. These do seem to fit in the installer (at least for 20.1.0-rc2), so let's add them back. [1] https://discourse.llvm.org/t/llvm-19-x-release-third-party-binaries/80374/26 [2] https://discourse.llvm.org/t/llvm-19-x-release-third-party-binaries/80374/53 [3] llvm#127120 [4] llvm#127794 (comment) (cherry picked from commit 6e047a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When including all targets, some files become too large for the NSIS installer to handle.
Fixes #101994