[NFC][TableGen] Refactor JSON and detailed record emitter #105770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurahul
force-pushed
the
tg_constref_backends
branch
from
116013b to
00665b8
Compare
jurahul
force-pushed
the
tg_constref_backends
branch
from
00665b8 to
9c42393
Compare
s-barannikov
approved these changes
Aug 26, 2024
Thanks, and agreed. The PR evolved over time. I was actually working on splitting it up since the JSON one has many changes (const ref, var name, no else after return etc), so I was thinking of splitting the JSON and Detailed as 2 separate PR. Let me know if that helps. (Its easy enough to do that) |
|
I think it is fine as is. |
- Fix JSON and detailed record emitters to use const reference and pointers. - Fix code to use C++ structured bindings and range based loops, include reverse() range for locations. - Eliminate `NL` define for "\n". - Change JSON emitter to populate `instance_list` in an earlier loop over superclasses instead of a separate loop.
jurahul
force-pushed
the
tg_constref_backends
branch
from
9c42393 to
6f69fd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NLdefine for "\n".instance_listin an earlier loop over superclasses instead of a separate loop.