[Driver] Restrict Ofast deprecation help message to Clang

[kiranchandramohan]

The discussion about this in Flang (https://discourse.llvm.org/t/rfc-deprecate-ofast-in-flang/80243) has not concluded hence restricting the deprecation only to Clang.

[llvmbot]

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: Kiran Chandramohan (kiranchandramohan)

Changes

The discussion about this in Flang (https://discourse.llvm.org/t/rfc-deprecate-ofast-in-flang/80243) has not concluded hence restricting the deprecation only to Clang.

---

Full diff: https://github.com/llvm/llvm-project/pull/101682.diff

1 Files Affected:

• (modified) clang/include/clang/Driver/Options.td (+3-2)

diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index f690467bb82cd..d13bc51811c3c 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -932,8 +932,9 @@ def O_flag : Flag<["-"], "O">, Visibility<[ClangOption, CC1Option, FC1Option]>,
   Alias<O>, AliasArgs<["1"]>;
 def Ofast : Joined<["-"], "Ofast">, Group<O_Group>,
   Visibility<[ClangOption, CC1Option, FlangOption]>,
-  HelpText<"Deprecated; use '-O3 -ffast-math' for the same behavior,"
-  " or '-O3' to enable only conforming optimizations">;
+  HelpTextForVariants<[ClangOption,CC1Option],
+                      "Deprecated; use '-O3 -ffast-math' for the same behavior,"
+                      " or '-O3' to enable only conforming optimizations">;
 def P : Flag<["-"], "P">,
   Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>,
   Group<Preprocessor_Group>,

[AaronBallman]

Thank you!

Changes LGTM; please give @MaskRay a day before landing though, in case he's got concerns. Once this lands, we should cherry-pick to 19.x

[AaronBallman]

Suggested change

	HelpTextForVariants<[ClangOption,CC1Option],
	HelpTextForVariants<[ClangOption, CC1Option],

[kiranchandramohan]

Made the change in the force-push.

[MaskRay]

Thanks for the clarification!
Cc some flang developers to confirm this and #101701 are the direction as https://discourse.llvm.org/t/rfc-deprecate-ofast-in-flang/80243 doesn't have lots of recorded discussion: @banach-space @clementval @klausler

[clementval]

Thanks for the clarification! Cc some flang developers to confirm this and #101701 are the direction as https://discourse.llvm.org/t/rfc-deprecate-ofast-in-flang/80243 doesn't have lots of recorded discussion: @banach-space @clementval @klausler

👍 This was discussed during the flang weekly call.

[kiranchandramohan]

/cherry-pick e60ee1f

[llvmbot]

/pull-request #101963