Skip to content

[Utils] Updates to bump-version.py #100089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions llvm/utils/release/bump-version.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@


class Processor:
def __init__(self, args):
self.args = args

def process_line(self, line: str) -> str:
raise NotImplementedError()

Expand All @@ -23,6 +26,13 @@ def process_file(self, fpath: Path, version: packaging.version.Version) -> None:
version.micro,
version.pre,
)

if self.args.rc:
self.suffix = f"-rc{self.args.rc}"

if self.args.git:
self.suffix = "git"

data = fpath.read_text()
new_data = []

Expand Down Expand Up @@ -64,7 +74,7 @@ def process_line(self, line: str) -> str:
if self.suffix:
nline = re.sub(
r"set\(LLVM_VERSION_SUFFIX(.*)\)",
f"set(LLVM_VERSION_SUFFIX -{self.suffix[0]}{self.suffix[1]})",
f"set(LLVM_VERSION_SUFFIX {self.suffix})",
line,
)
else:
Expand Down Expand Up @@ -144,6 +154,7 @@ def process_line(self, line: str) -> str:
)
parser.add_argument("version", help="Version to bump to, e.g. 15.0.1", default=None)
parser.add_argument("--rc", default=None, type=int, help="RC version")
parser.add_argument("--git", action="store_true", help="Git version")
parser.add_argument(
"-s",
"--source-root",
Expand All @@ -153,9 +164,10 @@ def process_line(self, line: str) -> str:

args = parser.parse_args()

if args.rc and args.git:
raise RuntimeError("Can't specify --git and --rc at the same time!")

verstr = args.version
if args.rc:
verstr += f"-rc{args.rc}"

# parse the version string with distutils.
# note that -rc will end up as version.pre here
Expand All @@ -170,20 +182,20 @@ def process_line(self, line: str) -> str:

files_to_update = (
# Main CMakeLists.
(source_root / "llvm" / "CMakeLists.txt", CMakeProcessor()),
(source_root / "cmake" / "Modules" / "LLVMVersion.cmake", CMakeProcessor(args)),
# Lit configuration
(
"llvm/utils/lit/lit/__init__.py",
LitProcessor(),
LitProcessor(args),
),
# GN build system
(
"llvm/utils/gn/secondary/llvm/version.gni",
GNIProcessor(),
GNIProcessor(args),
),
(
"libcxx/include/__config",
LibCXXProcessor(),
LibCXXProcessor(args),
),
)

Expand Down
Loading