AllowShortFunctionsOnASingleLine: InlineOnly and ColumnLimit: 0 behaves weirdly.

[tru]

This code:

class A {
  int GetVal1() const { return m_Val1; }
  int GetVal2() const { return m_Val2; }
};

Change the .clang-format to this:

AllowShortFunctionsOnASingleLine: InlineOnly
ColumnLimit: 0

and the result is:

class A {
  int GetVal1() const { return m_Val1; }
  int GetVal2() const {
    return m_Val2;
  }
};

If you set ColumnLimit: 120 it will reproduce the expected first result.

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: Tobias Hieta (tru)

This code:

class A {
  int GetVal1() const { return m_Val1; }
  int GetVal2() const { return m_Val2; }
};

Change the .clang-format to this:

AllowShortFunctionsOnASingleLine: InlineOnly
ColumnLimit: 0

and the result is:

class A {
  int GetVal1() const { return m_Val1; }
  int GetVal2() const {
    return m_Val2;
  }
};

If you set ColumnLimit: 120 it will reproduce the expected first result.

[tru]

Since @rymiel couldn't reproduce this, I started to poke at it again. And there seems to be a odd inconsistency:

If the source is formatted like this:

class A {
  int GetVal1() const {
    return m_Val1;
  }
  int GetVal2() const {
    return m_Val2;
  }
};

And you run it with ColumnLimit: 0 nothing will be reformatted, but if you set ColumnLimit > 0 it will "fix" formatting to

class A {
  int GetVal1() const { return m_Val1; }
  int GetVal2() const { return m_Val2; }
};

so it seems like AllowShortFunctionsOnASingleLine: InlineOnly is not really enforced with ColumnLimit: 0. Is this the expected behavior?

[llvmbot]

@llvm/issue-subscribers-bug

Author: Tobias Hieta (tru)

This code:

class A {
  int GetVal1() const { return m_Val1; }
  int GetVal2() const { return m_Val2; }
};

Change the .clang-format to this:

AllowShortFunctionsOnASingleLine: InlineOnly
ColumnLimit: 0

and the result is:

class A {
  int GetVal1() const { return m_Val1; }
  int GetVal2() const {
    return m_Val2;
  }
};

If you set ColumnLimit: 120 it will reproduce the expected first result.

[jpvbarbosa]

Not sure if this is worth opening it's own issue for, but I am seeing odd behaviour with AllowShortFunctionsOnASingleLine as well. With the following settings,

AllowShortFunctionsOnASingleLine: InlineOnly
ColumnLimit: 0
BreakConstructorInitializers: BeforeColon
PackConstructorInitializers: CurrentLine

When formatting the following the code,

MyClass::MyClass() : mOne{nullptr}, mTwo{nullptr}, mThree{3}
{
}

The result is

MyClass::MyClass()
    : mOne{nullptr}, mTwo{nullptr}, mThree{3}
{
}

Which is incorrect. The entire initializer list should be able to exist on the same line as MyClass::MyClass(), so formatting should result in no change to the first code snippet.

I played around with different combinations of BreakConstructorInitializers and PackConstructorInitializers, but the only things that produced the expected result in all cases was changing one of the following:

1. Setting ColumnLimit > 0, or
2. Setting AllowShortFunctionsOnASingleLine: All

I was very surprised that AllowShortFunctionsOnASingleLine had any effect in this context.

Full clang-format config, if it helps: clang-format.txt

[owenca]

Not sure if this is worth opening it's own issue for

@jpvbarbosa this seems to be a different issue. Please open its own.

[owenca]

Split to #119519.