[clang] -print-target-triple doesn't work properly on Apple platforms

[ldionne]

$ echo | clang -xc - -###
[...]/bin/clang" "-cc1" "-triple" "arm64-apple-macosx11.0.0" [...]

$ clang -print-target-triple
arm64-apple-darwin22.4.0

So we can see that the compiler knows (at some point) that it should be compiling for macosx11.0.0, but -print-target-triple doesn't know that yet. That's because -print-target-triple is implemented in HandleImmediateArgs which is run before the toolchains::Darwin object is initialized.

[llvmbot]

@llvm/issue-subscribers-clang-driver

[ldionne]

CC @Xazax-hun Do you think the fix is similar to what you did for #98325?

[Xazax-hun]

Probably something similar needs to be done for this as well, but I vaguely remember trying this out and had the impression doing the same change for this flag was not sufficient to get the desired results. I did not look deeply why this was the case, and it is also possible I was missing something obvious.

[Xazax-hun]

Actually, it only needed a minor change after initializing the targets early. Opened a PR: #104037

[Xazax-hun]

Reopening, since the PR was reverted. See the discussion at the PR why.

[ldionne]

Not sure why this was closed again @s-barannikov .

[s-barannikov]

I'm shocked. I just pushed some refs to my private clone of llvm. I couldn't imagine such a thing could happen.
This is how it is rendered on my side:

[ldionne]

@tstellar Are you aware of this? Is there a setting we could enable/disable in the monorepo to prevent issues from being closed from pushes to other repositories? That seems like a very dangerous thing to me.