Unused variables when building Bolt without asserts

[tschuett]

My Apple Clang is unhappy about a couple unused variables:

bool DataWritten = false;
bool IsTailCall = isTailCall(Inst);
bool Ret = evaluateMemOperandTarget(*Adrp, Base, AdrpPC, InstSize);
BinaryContext &BC = Function.getBinaryContext();
const bool IsCondBranch = MIB->isConditionalBranch(Instruction);
uint8_t Opcode = ExprBytes[0];
bool Valid = true;
bool Found = false;
bool Erased = false;

It is really unhappy about common.h. I have feeling there is a -std=c++14 missing.

[llvmbot]

@llvm/issue-subscribers-bolt

[aaupov]

Thanks for bug report. I've reproduced the build issue with Apple Clang.

[tschuett]

Sorry, but I believe that you missed:

bool Found = false;
bool Valid = true;
bool DataWritten = false;

[aaupov]

c1532ac should fix the build issue. I've tested it with Apple Clang 12.0.0.
139744a addresses unused variables.
253b8f0 fixes misc warnings.

[aaupov]

Sorry, but I believe that you missed:

bool Found = false;
bool Valid = true;
bool DataWritten = false;

Which Xcode/clang version did you use? Can you please provide the full CMake command?

[aaupov]

Additionally, da766ce enables testing on MacOS.
The command line I've used is the following:

cmake <llvm-project>/llvm -G Ninja -DLLVM_TARGETS_TO_BUILD="X86;AArch64" -DCMAKE_BUILD_TYPE=Release  -DLLVM_ENABLE_PROJECTS="bolt;lld" -DBOLT_CLANG_EXE=`which clang`
ninja check-bolt

We don't have macOS buildbots, so check-bolt is not guaranteed to stay green.

[tschuett]

variable 'DataWritten' set but not used:

llvm-project/bolt/lib/Rewrite/RewriteInstance.cpp

Line 4018 in 6f5f847

bool DataWritten = false;

variable 'Found' set but not used:

llvm-project/bolt/lib/Core/BinaryContext.cpp

Line 803 in 6f5f847

bool Found = false;

variable 'Valid' set but not used:

llvm-project/bolt/lib/Core/BinaryContext.cpp

Line 1163 in 6f5f847

bool Valid = true;

> clang --version
Apple clang version 13.1.6 (clang-1316.0.21.2.3)
Target: x86_64-apple-darwin21.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

[aaupov]

@tschuett thanks for clarification! Looks like I've used Clang from the wrong xcode installation. Can confirm the warnings now.