LLDB confuses multiple global variables with the same name (even when they are in different namespace)

[oontvoo]

Bugzilla Link	52582
Version	unspecified
OS	All
CC	@dwblaikie,@JDevlieghere,@oontvoo

Extended Description

Background
Our binary has multiple global variables with the same basename but in different namespaces. (Eg., lld::macho::symtab vs lld::elf::symtab, lld::macho::in vs lld::elf::in, ...)

Repro:
Run the LLD linker under LLDB: (best to use MachO port to demonstrate this bug):

lldb -- ld64.lld.darwninnew <... rest of args>

Set a breakpoint anywhere - but for best effect, here:

llvm-project/lld/MachO/Driver.cpp

Line 1141 in 2782cb8

target = createTargetInfo(args);

(ie., right after symtab is set)

Try and print symtab or in.got:

(lldb) b Driver.cpp:1139
Breakpoint 1: 3 locations.
(lldb) run
Process 13244 launched: '/Users/vyng/repo/llvm-project/build_lld/bin/ld64.lld.darwinnew' (x86_64)
Process 13244 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.2
    frame #0: 0x0000000100a0856f ld64.lld.darwinnew`lld::macho::link(argsArr=ArrayRef<const char *> @ 0x00007ff7bfefeeb0, canExitEarly=true, stdoutOS=0x00000001093b83a8, stderrOS=0x00000001093b8410) at Driver.cpp:1139:12
   1136	
   1137	  config = make<Configuration>();
   1138	  symtab = make<SymbolTable>();
-> 1139	  target = createTargetInfo(args);
   1140	  depTracker =
   1141	      make<DependencyTracker>(args.getLastArgValue(OPT_dependency_info));
   1142	  if (errorCount())
Target 0: (ld64.lld.darwinnew) stopped.
(lldb) print symtab
(lld::elf::SymbolTable *) $0 = nullptr
(lldb) print in.got
(lld::elf::GotSection *) $1 = nullptr
(lldb) print lld::macho::in.got

Expected:
Since the code that the breakpoint stopped on referred to the variable as simply symtab, I would have expected LLDB's print to allow me to also use symtab.

What actually happened:
LLDB always picked the globals from lld::elf .
(presumably because it's alphabetically before ::macho)

---

(Tested this with GDB and it didn't have this issue)

[PRESIDENT810]

Here's a minimal example that can reproduce this bug:

main.cpp

namespace bar {

  extern int global_var;

  int barmain() {
    int var = global_var;
    return global_var;
  }

}

int main() {
  int ret = bar::barmain();
  return 0;
}

foo.cpp

namespace foo {
  int global_var = 1;
}

bar.cpp

namespace bar{
  int global_var = 2;
}

Set a breakpoint at the end of function barmain, then input command p global_var, you will find the output value is 1; however, the correct value should be 1, which is the same value of var.