Some `NestedNameSpecifierLocs` have invalid source locations

[llvmbot]

Bugzilla Link	24742
Version	trunk
OS	Linux
Reporter	LLVM Bugzilla Contributor
CC	@DougGregor

Extended Description

A coworker suggested this to be the cause: https://github.com/llvm-mirror/clang/blob/298fde465765d930b8bcd588c613343a1c7805b3/lib/Sema/TreeTransform.h#L3260

I'm trying to write a little refactoring tool to replace foo with ::foo for a few error-prone cases (e.g. "utils"), but this got in my way.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: None (llvmbot)

| | | | --- | --- | | Bugzilla Link | [24742](https://llvm.org/bz24742) | | Version | trunk | | OS | Linux | | Reporter | LLVM Bugzilla Contributor | | CC | @DougGregor |

Extended Description

A coworker suggested this to be the cause: https://github.com/llvm-mirror/clang/blob/298fde465765d930b8bcd588c613343a1c7805b3/lib/Sema/TreeTransform.h#L3260

I'm trying to write a little refactoring tool to replace foo with ::foo for a few error-prone cases (e.g. "utils"), but this got in my way.

[AaronBallman]

I believe this issue is now resolved, as Extend() calculates the source range information itself rather than relying on the caller to pass in a valid source location. If the issue still reproduces for you, feel free to reopen the issue but provide a reproducer.