[ASAN / AArch64] forkpty fails on AArch64

[rengolin]

Bugzilla Link	24400
Version	trunk
OS	Linux
CC	@zatrazz,@eugenis,@kcc,@rengolin,@vitalybuka

Extended Description

Investigate why this is failing.

[vitalybuka]

Investigate why this is failing.

Any updates?

[rengolin]

Hi Vitaly,

I haven't done any investigation around this since reporting the bug and I'm not sure it's still an issue. Feel free to investigate.

Thanks!
--renato

[c-rhodes]

I had a quick look at this one. Wasnt immediately obvious exactly what was failing until I found 86474c7, which is disabling the test this refers to. I re-enabled it:

diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp
index 2711cfb11295..a4ca4a3c2f35 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp
@@ -3,7 +3,6 @@
 // Ignore leaks as this is not the point of test, but HWASAN repors one here.
 // RUN: %env_tool_opts=detect_leaks=0 %run %t | FileCheck %s

-// REQUIRES: stable-runtime
 // XFAIL: android && asan

 // No libutil.

and it's passing for me on my Graviton3 instance:

build/./bin/llvm-lit -sv build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-aarch64-Linux --filter getpass.cpp -a
PASS: SanitizerCommon-asan-aarch64-Linux :: Posix/getpass.cpp (1 of 1)
Exit Code: 0

Command Output (stderr):
--
RUN: at line 1: /home/culrho01/llvm-project/build/./bin/clang  --driver-mode=g++ -gline-tables-only -fsanitize=address   -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta  -funwind-tables  -I/home/culrho01/llvm-project/compiler-rt/test -ldl -O0 -g /home/culrho01/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp -lutil -o /home/culrho01/llvm-project/build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-aarch64-Linux/Posix/Output/getpass.cpp.tmp
+ /home/culrho01/llvm-project/build/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=address -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -funwind-tables -I/home/culrho01/llvm-project/compiler-rt/test -ldl -O0 -g /home/culrho01/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp -lutil -o /home/culrho01/llvm-project/build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-aarch64-Linux/Posix/Output/getpass.cpp.tmp
RUN: at line 4: env ASAN_OPTIONS=detect_leaks=0  /home/culrho01/llvm-project/build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-aarch64-Linux/Posix/Output/getpass.cpp.tmp | FileCheck /home/culrho01/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp
+ env ASAN_OPTIONS=detect_leaks=0 /home/culrho01/llvm-project/build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-aarch64-Linux/Posix/Output/getpass.cpp.tmp
+ FileCheck /home/culrho01/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp

--

********************

Testing Time: 0.23s

Total Discovered Tests: 239
  Excluded: 238 (99.58%)
  Passed  :   1 (0.42%)

I think this can be re-enabled. Although arm and armhf aren't "stable-runtime"'s either, but perhaps could add

// UNSUPPORTED: (arm-target-arch || armhf-target-arch)

if is that's an issue.