[clang] Review `AP(S)Int` values in diagnostic messages and try to use new separator API

[tbaederr]

With #161047 merged, we can now output APSInt and APInt values in diagnostic messages more easily.

We should

1. Review the toString() usage in diagnostic message emission and review if we should instead use the new << Value version.
2. If so, do that and if there's no test that fails, add a new one

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Timm Baeder (tbaederr)

With github.com//pull/161047 merged, we can now output `APSInt` and `APInt` values in diagnostic messages more easily.

We should

1. Review the toString() usage in diagnostic message emission and review if we should instead use the new << Value version.
2. If so, do that and if there's no test that fails, add a new one

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor is working on this issue. If someone is assigned to the issue or claimed to be working on it, ping the person. After one week without a response, the assignee may be changed.
2. Leave a comment indicating that you are working on the issue, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Timm Baeder (tbaederr)

With github.com//pull/161047 merged, we can now output `APSInt` and `APInt` values in diagnostic messages more easily.

We should

1. Review the toString() usage in diagnostic message emission and review if we should instead use the new << Value version.
2. If so, do that and if there's no test that fails, add a new one

[snarang181]

I have a WIP PR: #161474