[clang-tidy] Check request: performance-incorrect-move-with-smart-pointer-cast

[denzor200]

Need a check that will find incorrect usage of std::move with smart pointer casts (e.g., std::static_pointer_cast, std::dynamic_pointer_cast, their boost analogues, etc).

BEFORE:

std::shared_ptr<B> b = std::move(std::dynamic_pointer_cast<B>(a));

AFTER:

std::shared_ptr<B> b = std::dynamic_pointer_cast<B>(std::move(a));

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Denis Mikhailov (denzor200)

Need a check that will find incorrect usage of `std::move` with smart pointer casts (e.g., `std::static_pointer_cast`, `std::dynamic_pointer_cast`, their `boost` analogues, etc).

BEFORE:

std::shared_ptr<B> b = std::move(std::dynamic_pointer_cast<B>(a));

AFTER:

std::shared_ptr<B> b = std::dynamic_pointer_cast<B>(std::move(a));