HTTPClient.cpp: fails to build with `error: 'errc' has not been declared`

[sylvestre]

Recent regression:

FAILED: lib/Debuginfod/CMakeFiles/LLVMDebuginfod.dir/HTTPClient.cpp.o
/usr/bin/g++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/source/build-llvm/lib/Debuginfod -I/build/source/llvm/lib/Debuginfod -I/build/source/build-llvm/include -I/build/source/llvm/include -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wno-unused-command-line-argument -Wdate-time -D_FORTIFY_SOURCE=3 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fdebug-prefix-map=/build/source/build-llvm=../ -fdebug-prefix-map=/build/source/= -no-canonical-prefixes -ffile-prefix-map=/build/source/build-llvm=../ -ffile-prefix-map=/build/source/= -no-canonical-prefixes -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -MD -MT lib/Debuginfod/CMakeFiles/LLVMDebuginfod.dir/HTTPClient.cpp.o -MF lib/Debuginfod/CMakeFiles/LLVMDebuginfod.dir/HTTPClient.cpp.o.d -o lib/Debuginfod/CMakeFiles/LLVMDebuginfod.dir/HTTPClient.cpp.o -c /build/source/llvm/lib/Debuginfod/HTTPClient.cpp
/build/source/llvm/lib/Debuginfod/HTTPClient.cpp: In member function 'llvm::Error llvm::HTTPClient::perform(const llvm::HTTPRequest&, llvm::HTTPResponseHandler&)':
/build/source/llvm/lib/Debuginfod/HTTPClient.cpp:107:30: error: 'errc' has not been declared
  107 |     return createStringError(errc::invalid_argument,
      |                              ^~~~
/build/source/llvm/lib/Debuginfod/HTTPClient.cpp:125:41: error: 'errc' has not been declared
  125 |                       createStringError(errc::io_error,
      |                                         ^~~~

[sylvestre]

seems that @kazutakahirata introduced this regression in:
#142733

log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-noble-binaries/architecture=arm64,distribution=noble,label=arm64/839/console

cc @arsenm

[kazutakahirata]

@sylvestre I'll take a look. Thank you for letting me know!

[Prabhuk]

Our toolchain builders are failing with the same failure as well. https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8712965347943652289/+/u/clang/build/stdout

FAILED: lib/Debuginfod/CMakeFiles/LLVMDebuginfod.dir/HTTPServer.cpp.o 
/b/s/w/ir/x/w/rc/cxx-rbeelf4nrs7/reclient-cxx-wrapper.sh /b/s/w/ir/x/w/cipd/bin/clang++ --sysroot=/b/s/w/ir/x/w/cipd/linux -DCPPHTTPLIB_ZLIB_SUPPORT -DCURL_STATICLIB -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/s/w/ir/x/w/llvm_build/lib/Debuginfod -I/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/Debuginfod -I/b/s/w/ir/x/w/rc/tensorflow-venv/store/python_venv-nacb1phkpgklqiq46g3ivnt518/contents/lib/python3.8/site-packages/tensorflow/include -I/b/s/w/ir/x/w/llvm_build/include -I/b/s/w/ir/x/w/llvm-llvm-project/llvm/include -isystem /b/s/w/ir/x/w/install-curl-x86_64-linux-gnu/include -isystem /b/s/w/ir/x/w/install-boringssl-x86_64-linux-gnu/include -isystem /b/s/w/ir/x/w/install-zlib-x86_64-linux-gnu/include -isystem /b/s/w/ir/x/w/install-cpp-httplib-x86_64-linux-gnu/include -isystem /b/s/w/ir/x/w/install-zstd-x86_64-linux-gnu/include -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffat-lto-objects -ffile-prefix-map=/b/s/w/ir/x/w/llvm_build=../llvm-llvm-project -ffile-prefix-map=/b/s/w/ir/x/w/llvm-llvm-project/= -no-canonical-prefixes -O3 -DNDEBUG -std=c++17 -fvisibility=default  -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -MD -MT lib/Debuginfod/CMakeFiles/LLVMDebuginfod.dir/HTTPServer.cpp.o -MF lib/Debuginfod/CMakeFiles/LLVMDebuginfod.dir/HTTPServer.cpp.o.d -o lib/Debuginfod/CMakeFiles/LLVMDebuginfod.dir/HTTPServer.cpp.o -c /b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/Debuginfod/HTTPServer.cpp
/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/Debuginfod/HTTPServer.cpp:115:30: error: use of undeclared identifier 'errc'; did you mean 'std::errc'?
  115 |     return createStringError(errc::argument_out_of_domain, ErrorMessage);
      |                              ^~~~
      |                              std::errc
/b/s/w/ir/x/w/cipd/bin/../include/c++/v1/__system_error/errc.h:143:29: note: 'std::errc' declared here
  143 | _LIBCPP_DECLARE_STRONG_ENUM(errc){
      |                             ^
/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/Debuginfod/HTTPServer.cpp:115:12: error: no matching function for call to 'createStringError'
  115 |     return createStringError(errc::argument_out_of_domain, ErrorMessage);
      |            ^~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/llvm/include/llvm/Support/Error.h:1333:14: note: candidate function template not viable: no known conversion from 'std::string' (aka 'basic_string<char>') to 'const char *' for 2nd argument
 1333 | inline Error createStringError(std::errc EC, char const *Fmt,
      |              ^                               ~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/llvm/include/llvm/Support/Error.h:1328:14: note: candidate function template not viable: no known conversion from 'std::errc' to 'const char *' for 1st argument
 1328 | inline Error createStringError(char const *Fmt, const Ts &...Vals) {
      |              ^                 ~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/llvm/include/llvm/Support/Error.h:1318:14: note: candidate function not viable: no known conversion from 'std::errc' to 'std::error_code' for 1st argument
 1318 | inline Error createStringError(std::error_code EC, const Twine &S) {
      |              ^                 ~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/llvm/include/llvm/Support/Error.h:1305:14: note: candidate function template not viable: no known conversion from 'std::errc' to 'std::error_code' for 1st argument
 1305 | inline Error createStringError(std::error_code EC, char const *Fmt,
      |              ^                 ~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/llvm/include/llvm/Support/Error.h:1312:16: note: candidate function not viable: no known conversion from 'std::errc' to 'std::string' (aka 'basic_string<char>') for 1st argument
 1312 | LLVM_ABI Error createStringError(std::string &&Msg, std::error_code EC);
      |                ^                 ~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/llvm/include/llvm/Support/Error.h:1314:14: note: candidate function not viable: no known conversion from 'std::errc' to 'std::error_code' for 1st argument
 1314 | inline Error createStringError(std::error_code EC, const char *S) {
      |              ^                 ~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/llvm/include/llvm/Support/Error.h:1323:14: note: candidate function not viable: requires single argument 'S', but 2 arguments were provided
 1323 | inline Error createStringError(const Twine &S) {
      |              ^                 ~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/Debuginfod/HTTPServer.cpp:127:30: error: use of undeclared identifier 'errc'; did you mean 'std::errc'?
  127 |     return createStringError(errc::io_error,
      |                              ^~~~
      |                              std::errc
/b/s/w/ir/x/w/cipd/bin/../include/c++/v1/__system_error/errc.h:143:29: note: 'std::errc' declared here
  143 | _LIBCPP_DECLARE_STRONG_ENUM(errc){
      |                             ^
/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/Debuginfod/HTTPServer.cpp:136:30: error: use of undeclared identifier 'errc'; did you mean 'std::errc'?
  136 |     return createStringError(errc::io_error,
      |                              ^~~~
      |                              std::errc
/b/s/w/ir/x/w/cipd/bin/../include/c++/v1/__system_error/errc.h:143:29: note: 'std::errc' declared here
  143 | _LIBCPP_DECLARE_STRONG_ENUM(errc){
      |                             ^
/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/Debuginfod/HTTPServer.cpp:143:30: error: use of undeclared identifier 'errc'; did you mean 'std::errc'?
  143 |     return createStringError(errc::io_error,
      |                              ^~~~
      |                              std::errc
/b/s/w/ir/x/w/cipd/bin/../include/c++/v1/__system_error/errc.h:143:29: note: 'std::errc' declared here
  143 | _LIBCPP_DECLARE_STRONG_ENUM(errc){
      |                             ^
/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/Debuginfod/HTTPServer.cpp:147:9: error: use of undeclared identifier 'errc'; did you mean 'std::errc'?
  147 |         errc::io_error,
      |         ^~~~
      |         std::errc
/b/s/w/ir/x/w/cipd/bin/../include/c++/v1/__system_error/errc.h:143:29: note: 'std::errc' declared here
  143 | _LIBCPP_DECLARE_STRONG_ENUM(errc){
      |                             ^
6 errors generated.

[kazutakahirata]

@sylvestre @Prabhuk I've landed 450d130 to restore a couple of includes in HTTPServer.cpp. Thanks!

[ilovepi]

@kazutakahirata We're still seeing those failures after 450d130.

Bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-host-linux-x64/b8712959076139394849/overview
Log: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8712959076139394849/+/u/clang/build/stdout

Not sure why, though.

[kazutakahirata]

@ilovepi It turns out that I needed to restore llvm/lib/Debuginfod/HTTPServer.cpp in addition to Debuginfod/HTTPClient.cpp. I've landed 62fc146 to fix the build failure. Thank you for reporting the build failure!

[ilovepi]

@ilovepi It turns out that I needed to restore llvm/lib/Debuginfod/HTTPServer.cpp in addition to Debuginfod/HTTPClient.cpp. I've landed 62fc146 to fix the build failure. Thank you for reporting the build failure!

Bots are green again. Thanks for the fix :)