Clang-Tidy 19 incorrectly replaces std::expected with std::unexpected

[magnesj]

The following line in ResInsight is incorrectly updated by clang-tidy-19

std::expected<caf::PdmObjectHandle, QString> result = method->execute();
is changed to
std::unexpected<caf::PdmObjectHandle, QString> result = method->execute();

Using auto result = method->execute(); works correct without any issues.

https://github.com/OPM/ResInsight/blob/7899736f0501f742e45e6dd6022e75136251a6bd/GrpcInterface/RiaGrpcPdmObjectService.cpp#L556

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Magne Sjaastad (magnesj)

The following line in ResInsight is incorrectly updated by clang-tidy-19

std::expected<caf::PdmObjectHandle, QString> result = method->execute();
is changed to
std::unexpected<caf::PdmObjectHandle, QString> result = method->execute();

Using auto result = method->execute(); works correct without any issues.

https://github.com/OPM/ResInsight/blob/7899736f0501f742e45e6dd6022e75136251a6bd/GrpcInterface/RiaGrpcPdmObjectService.cpp#L556

[carlosgalvezp]

Please provide a minimal reproducible example, as well as which particular check this issue is related to.

[EugeneZelenko]

https://godbolt.org should be helpful.