[clangd] end of line /// comment on member incorrectly attached to following member

[RedBeard0531]

For end-of-line comments like int foo; /// foo clangd will attach the comment to the next member rather than the one it shares a line with. This seems to clearly be missing the intent of the developer even if the doxygen spec says they should be using ///< foo. Any end-of-line comment always is assumed (by humans) to attach to the code is shares a line with, even if comments attach to the next thing when the whole line is a comment.

struct S {
    int foo; /// ***foo***
    int bar;
};

int x = S().bar; 

Hovering over the last bar shows the doc comment ***foo***.

[llvmbot]

@llvm/issue-subscribers-clangd

Author: Mathias Stearn (RedBeard0531)

For end-of-line comments like `int foo; /// foo clangd` will attach the comment to the next member rather than the one it shares a line with. This seems to clearly be missing the intent of the developer even if the doxygen spec says they should be using `///< foo`. Any end-of-line comment always is assumed (by humans) to attach to the code is shares a line with, even if comments attach to the next thing when the whole line is a comment.

struct S {
    int foo; /// ***foo***
    int bar;
};

int x = S().bar; 

Hovering over the last bar shows the doc comment ***foo***.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Mathias Stearn (RedBeard0531)

For end-of-line comments like `int foo; /// foo clangd` will attach the comment to the next member rather than the one it shares a line with. This seems to clearly be missing the intent of the developer even if the doxygen spec says they should be using `///< foo`. Any end-of-line comment always is assumed (by humans) to attach to the code is shares a line with, even if comments attach to the next thing when the whole line is a comment.

struct S {
    int foo; /// ***foo***
    int bar;
};

int x = S().bar; 

Hovering over the last bar shows the doc comment ***foo***.

[HighCommander4]

Added clang:frontend as well because the relevant code is in libAST (around here) and may have other clients besides clangd.

[RedBeard0531]

Interestingly it already seems to do the right thing for // comments like int foo; // foo, so it is just that /// should probably behave more like //.