[clang-tidy] Check request: readability-use-switch-statement

[denzor200]

Needs a check that will find a chained if-else statement and suggest to change it to use switch-statement.

BEFORE:

if (i == 1) {
    std::cout << "first" << std::endl;
} else if (i == 2) {
    std::cout << "second" << std::endl;
} else if (i == 3) {
    std::cout << "third" << std::endl;
}

AFTER:

switch (i) {
case 1:
    std::cout << "first" << std::endl;
    break;
case 2:
    std::cout << "second" << std::endl;
    break;
case 3:
    std::cout << "third" << std::endl;
    break;
default:
    break;
}

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Denis Mikhailov (denzor200)

Needs a check that will find a chained if-else statement and suggest to change it to use switch-statement.

BEFORE:

if (i == 1) {
    std::cout << "first" << std::endl;
} else if (i == 2) {
    std::cout << "second" << std::endl;
} else if (i == 3) {
    std::cout << "third" << std::endl;
}

AFTER:

switch (i) {
case 1:
    std::cout << "first" << std::endl;
    break;
case 2:
    std::cout << "second" << std::endl;
    break;
case 3:
    std::cout << "third" << std::endl;
    break;
default:
    break;
}

[LegalizeAdulthood]

Lots of IDEs (and clang-tidy) have existing checks revolving around the use of switch statements to look for missing cases, etc. Make sure that this check doesn't lead to "ping ponging" of advice, e.g. suggest you use a switch statement and then complains about the switch statement.