[flang][OpenMP] "Call parameter type does not match function signature!" for private variables

[mjklemm]

When compiling the below rerproducer, the compiler asserts with the following message:

> flang-new -fopenmp --offload-arch=gfx90a -c bad_signature_reproducer.f90 -o bad_signature_reproducer.o
flang-21: warning: OpenMP support in flang is still experimental [-Wexperimental-option]
flang-21: warning: OpenMP support in flang is still experimental [-Wexperimental-option]
flang-21: warning: OpenMP support in flang is still experimental [-Wexperimental-option]
Call parameter type does not match function signature!
  %omp.private.alloc = alloca i32, align 4, addrspace(5)
 ptr  call void @_QMotherProutine(ptr addrspace(5) %omp.private.alloc)
error: failed to create the LLVM module

This seems to be a regression that was introduced with #124019.

Reproducer:

module other
contains
    subroutine routine(i)
        implicit none
        integer(4) :: i
    end subroutine routine
end module other

module mod
    implicit none
contains
    subroutine failing(d)
        use other, only: routine
        implicit none
        integer(4) :: i, d

        !$omp target teams distribute parallel do
        do i = 1, d
            call routine(i)
        end do
    end subroutine failing
end module mod

[mjklemm]

@tblah Can you please have a look if my assessment of a regression of #124019 is correct and something that you'd like to have a look at?

[llvmbot]

@llvm/issue-subscribers-flang-ir

Author: Michael Klemm (mjklemm)

When compiling the below rerproducer, the compiler asserts with the following message:

> flang-new -fopenmp --offload-arch=gfx90a -c bad_signature_reproducer.f90 -o bad_signature_reproducer.o
flang-21: warning: OpenMP support in flang is still experimental [-Wexperimental-option]
flang-21: warning: OpenMP support in flang is still experimental [-Wexperimental-option]
flang-21: warning: OpenMP support in flang is still experimental [-Wexperimental-option]
Call parameter type does not match function signature!
  %omp.private.alloc = alloca i32, align 4, addrspace(5)
 ptr  call void @<!-- -->_QMotherProutine(ptr addrspace(5) %omp.private.alloc)
error: failed to create the LLVM module

This seems to be a regression that was introduced with #124019.

Reproducer:

module other
contains
    subroutine routine(i)
        implicit none
        integer(4) :: i
    end subroutine routine
end module other

module mod
    implicit none
contains
    subroutine failing(d)
        use other, only: routine
        implicit none
        integer(4) :: i, d

        !$omp target teams distribute parallel do
        do i = 1, d
            call routine(i)
        end do
    end subroutine failing
end module mod