-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Closed
Labels
HLSLHLSL Language SupportHLSL Language Supportclang:frontendLanguage frontend issues, e.g. anything involving "Sema"Language frontend issues, e.g. anything involving "Sema"
Description
This issue handles the additional semantic analysis of the parsed HLSLRootSignature attribute. This includes generating applicable diagnostics.
The relevant validations that this issue must implement are:
- Validate that resource ranges don't overlap
- Ensure that registers are only bound once
See previous validation implementation for reference on range analysis.
Dependent on: #126577 and #126569
AC:
- Update
ParseHLSLRootSignaturedefined in [HLSL] Generate AST for Root Signatures #119011 to implement semantic validation ofHLSLRootSignature - Update
handleHLSLRootSignatureto implement semantic validation ofHLSLRootSignatureinSemaHLSL.cpp - Add thorough testing of correct diagnostics into
clang/unittests/Sema/ParseHLSLRootSignatureTest.cpp - Add tests for some samples to ensure diagnostics are displayed correctly from HLSL input in
AST/HLSL/RootSignatures-AST.hlsl
Metadata
Metadata
Assignees
Labels
HLSLHLSL Language SupportHLSL Language Supportclang:frontendLanguage frontend issues, e.g. anything involving "Sema"Language frontend issues, e.g. anything involving "Sema"
Type
Projects
Status
Closed