[MLIR] mlir::affine::simplifyConstrainedMinMaxOp creates null operands

[bondhugula]

@matthias-springer - this appears to be authored by you (didn't carefully check full history though). The code is sending potentially null Values to canonicalizeMapAndOperands (newOperands can have null Values). You can't send null operands to the method regardless of whether their identifiers appear in the map. So this is a bug.

llvm-project/mlir/lib/Dialect/Affine/Analysis/Utils.cpp

Line 2282 in 9b7282e

unpackOptionalValues(constraints.getMaybeValues(), newOperands);

[llvmbot]

@llvm/issue-subscribers-mlir-affine

Author: Uday Bondhugula (bondhugula)

@matthias-springer - this appears to be authored by you (didn't carefully check full history though). The code is sending potentially null `Value`s to canonicalizeMapAndOperands (`newOperands` can have null Values). You can't send null operands to the method regardless of whether their identifiers appear in the map. So this is a bug.

llvm-project/mlir/lib/Dialect/Affine/Analysis/Utils.cpp

Line 2282 in 9b7282e

unpackOptionalValues(constraints.getMaybeValues(), newOperands);

[llvmbot]

@llvm/issue-subscribers-bug

Author: Uday Bondhugula (bondhugula)

@matthias-springer - this appears to be authored by you (didn't carefully check full history though). The code is sending potentially null `Value`s to canonicalizeMapAndOperands (`newOperands` can have null Values). You can't send null operands to the method regardless of whether their identifiers appear in the map. So this is a bug.

llvm-project/mlir/lib/Dialect/Affine/Analysis/Utils.cpp

Line 2282 in 9b7282e

unpackOptionalValues(constraints.getMaybeValues(), newOperands);

[bondhugula]

@matthias-springer do you want to fix this? (shouldn't be a major change)

[matthias-springer]

Do you have a reproducer? I'm wondering what's the best way to trigger this.