Skip to content

[SPIR-V] Prefer SPV_INTEL_optnone over SPV_EXT_optnone when both extensions are available #122075

Closed
@VyacheslavLevytskyy

Description

@VyacheslavLevytskyy

Current implementation of support for the SPIR-V extension SPV_EXT_optnone prefers it over SPV_INTEL_optnone when both extensions are available. However, this leads to issues during run-time when a target knows about SPV_INTEL_optnone but not about SPV_EXT_optnone -- note that SPV_INTEL_optnone exists for a long time and SPV_EXT_optnone is a freshly introduced substitution of this extension.

To remediate the issue it'd be enough to simply change the order of picking one of those extensions when both are available, preferring SPV_INTEL_optnone over SPV_EXT_optnone to widen support of target systems. This solution would not change anything when a target specifies a required extension explicitly rather than allowing any of those (e.g., by providing --spirv-ext=all command line argument).

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions