Skip to content

[DirectX] Update DXContainerGlobals to get the shader flags from metadata rather than analysis #120152

Open
@bogner

Description

@bogner

DXContainerGlobals currently grabs shader flags from the analysis. This seems reasonable at a high level, but there are a couple of caveats:

  1. We'd like to disallow running shader flags analysis after op lowering (See [DirectX] Run shader flags analysis before DXILOpLowering #120119), which means this would need to rely on the flags analysis being preserved since then
  2. The flags are already embedded in DXIL metadata at this point, so we should just be able to copy them from there.

We should update the pass to simply pull the flags in an opaque way from metadata and put them into the appropriate container part.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Ready

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions