[HLSL] Update DXIL/SPIRV hybrid CodeGen tests to use a temp variable representing interchange target

[pow2clk]

@farzonl suggested creating this issue to update some existing hybrid tests to leverage the regexp variables in filecheck to minimize duplication of CHECK lines.

See

llvm-project/clang/test/CodeGenHLSL/builtins/dot.hlsl

Lines 22 to 30 in 319c7a4

	// Capture the expected interchange format so not every check needs to be duplicated
	// DXCHECK: %hlsl.dot = call i32 @llvm.[[ICF:dx]].sdot.v2i32(<2 x i32>
	// SPVCHECK: %hlsl.dot = call i32 @llvm.[[ICF:spv]].sdot.v2i32(<2 x i32>
	// CHECK: ret i32 %hlsl.dot
	int test_dot_int2(int2 p0, int2 p1) { return dot(p0, p1); }
	// CHECK: %hlsl.dot = call i32 @llvm.[[ICF]].sdot.v3i32(<3 x i32>
	// CHECK: ret i32 %hlsl.dot
	int test_dot_int3(int3 p0, int3 p1) { return dot(p0, p1); }

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Greg Roth (pow2clk)

@farzonl suggested creating this issue to update some existing hybrid tests to leverage the regexp variables in filecheck to minimize duplication of CHECK lines.

See

llvm-project/clang/test/CodeGenHLSL/builtins/dot.hlsl

Lines 22 to 30 in 319c7a4

	// Capture the expected interchange format so not every check needs to be duplicated
	// DXCHECK: %hlsl.dot = call i32 @llvm.[[ICF:dx]].sdot.v2i32(<2 x i32>
	// SPVCHECK: %hlsl.dot = call i32 @llvm.[[ICF:spv]].sdot.v2i32(<2 x i32>
	// CHECK: ret i32 %hlsl.dot
	int test_dot_int2(int2 p0, int2 p1) { return dot(p0, p1); }
	// CHECK: %hlsl.dot = call i32 @llvm.[[ICF]].sdot.v3i32(<3 x i32>
	// CHECK: ret i32 %hlsl.dot
	int test_dot_int3(int3 p0, int3 p1) { return dot(p0, p1); }

[AmrDeveloper]

Interested, I can work on it

[pow2clk]

Hey great! I don't have a list of tests that might need this treatment, but they will all be in the same directory: https://github.com/llvm/llvm-project/tree/319c7a42ba2e5be56757d622747ba317d3b9e9ad/clang/test/CodeGenHLSL