[clang-format] Wrong spacing around arithmetic operator?

[prj-]

I'm not sure these two should by formatted differently?

$ clang-format bug.c
v[num] = ((PetscReal)(numj)*HxdHy + (PetscReal)(numi)*HydHx);
v[num] = ((PetscReal)numj * HxdHy + (PetscReal)numi * HydHx);

This is with both version 18 and 20.

[owenca]

Why the parentheses surrounding numi and numj? Is the assignment in a macro definition?

[prj-]

No particular reason. They are superfluous, but should that impact the formatting?

Is the assignment in a macro definition?

No, see https://gitlab.com/petsc/petsc/-/blob/d12c03bb9366654d4a9fa52859dc383448383aea/src/ksp/ksp/tutorials/ex32.c#L173

[owenca]

No particular reason. They are superfluous, but should that impact the formatting?

Yes, because it could be a chained cast if numi and numj are types and HydHx and HydHx are pointers.

[prj-]

I see. So no easy way to get this formatted the same in both cases?

[owenca]

No, because there's no way to tell clang-format that numi is not a type.

[rymiel]

How common is a chained cast?

[owenca]

I would say not very common. @mydeveloperday added the support in https://reviews.llvm.org/D116592, which fixed #52979. Maybe we can narrow it down to chained pointer types only.

[prj-]

I have removed most of our superfluous parentheses, so feel free to close this issue if you don't think this is appropriate.