Skip to content

Add --build-tool-options to pass options to make/ninja/etc. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/quickstart.rst
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@ command. The information below should be enough to get you started, but see the
The ``SANDBOX`` value is a path to where the test suite build products and
results will be stored (inside a timestamped directory, by default).

We recommend adding ``--build-tool-options "-k"`` (if you are using ``make``)
or ``--build-tool-options "-k 0"`` (if you are using ``ninja``). This ensures
that the build tool carries on building even if there is a compilation
failure in one of the tests. Without these options, every test after the
compilation failure will not be compiled and will be reported as a missing
executable.

#. On most systems, the execution time results will be a bit noisy. There are
a range of things you can do to reduce noisiness (with LNT runtest test-suite
command line options when available between brackets):
Expand Down
6 changes: 5 additions & 1 deletion lnt/tests/test_suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,8 @@ def _build(self, path):
'--build', '.',
'-t', target,
'-j', str(self._build_threads())] +
([] if self.opts.succinct else ["-v"]),
([] if self.opts.succinct else ["-v"]) +
["--"] + shlex.split(self.opts.build_tool_options),
cwd=subdir)
except subprocess.CalledProcessError:
# cmake is expected to exit with code 1 if there was any build
Expand Down Expand Up @@ -1168,6 +1169,9 @@ def diagnose(self):
@click.option("--use-make", "make", metavar="PATH",
type=click.UNPROCESSED,
help="Path to the build system tool [make/ninja/...]")
@click.option("--build-tool-options",
help="Options to pass to the build system tool",
type=click.UNPROCESSED)
@click.option("--use-lit", "lit", metavar="PATH", type=click.UNPROCESSED,
default="llvm-lit",
help="Path to the LIT test runner [llvm-lit]")
Expand Down