[CIR][CodeGen] adds array size into AllocaOp #340

gitoleg · 2023-11-28T11:13:08Z

This PR adds array size into AllocaOp that will be useful in future - currently I work on variable length array support. So I start to make tiny PRs in advance)
No changes in tests needed, I tried to make the changes as smooth as possible, so no existing AllocaOp usages need to be changed.

sitio-couto

@gitoleg thanks for tackling VLAs!

Could you add a few tests in clang/test/CIR/?

In IR/alloca.cir, ensure the new AllocaOp is properly parsed/printed.
In IR/invalid.cir, ensure that invalid renditions of the AllocaOp will throw an error (e.g. array size as a float).
In Lowering/alloca.cir, ensure the lowering to LLVM IR of the AllocaOp is as expected.

clang/include/clang/CIR/Dialect/IR/CIROps.td

gitoleg · 2023-11-29T14:34:50Z

@sitio-couto done!

sitio-couto

@gitoleg just a few minor improvements to the tests.

Other than that, LGTM!

clang/test/CIR/Lowering/alloca.cir

clang/test/CIR/IR/alloca.cir

clang/test/CIR/IR/invalid.cir

clang/include/clang/CIR/Dialect/IR/CIROps.td

bcardosolopes · 2023-11-29T23:24:25Z

Thanks for adding VLA support, yay!

This PR adds array size into AllocaOp that will be useful in future - currently I work on variable length array support. So I start to make tiny PRs in advance)

Perfect!

clang/include/clang/CIR/Dialect/IR/CIROps.td

clang/test/CIR/IR/alloca.cir

gitoleg · 2023-11-30T11:38:23Z

@bcardosolopes @sitio-couto fixed

clang/include/clang/CIR/Dialect/IR/CIROps.td

gitoleg · 2023-12-01T13:02:06Z

@bcardosolopes @sitio-couto

so... I made tests mote concise and fixed the description of the new argument. Did I understand right your suggestions?

bcardosolopes

LGTM

This PR adds dynamic stack allocation into `AllocaOp` that will be useful in future - currently I work on variable length array support. So I start to make tiny PRs in advance) No changes in tests needed, I tried to make the changes as smooth as possible, so no existing `AllocaOp` usages need to be changed.

This is a first PR for variable length array support. There are one (or more :) ) ahead. Basically, we already did lot's of preliminary job in order to land VLA in CIR in #367 #346 #340. So now we add initial VLA support itself. Most of the changes are taken from the original codegen, so there is nothing to be scary of) I added just one test, and basically that's all we can test right now. Later, I will add more, from the original codegen tests.

This PR adds dynamic stack allocation into `AllocaOp` that will be useful in future - currently I work on variable length array support. So I start to make tiny PRs in advance) No changes in tests needed, I tried to make the changes as smooth as possible, so no existing `AllocaOp` usages need to be changed.

This is a first PR for variable length array support. There are one (or more :) ) ahead. Basically, we already did lot's of preliminary job in order to land VLA in CIR in #367 #346 #340. So now we add initial VLA support itself. Most of the changes are taken from the original codegen, so there is nothing to be scary of) I added just one test, and basically that's all we can test right now. Later, I will add more, from the original codegen tests.

This PR adds dynamic stack allocation into `AllocaOp` that will be useful in future - currently I work on variable length array support. So I start to make tiny PRs in advance) No changes in tests needed, I tried to make the changes as smooth as possible, so no existing `AllocaOp` usages need to be changed.

This is a first PR for variable length array support. There are one (or more :) ) ahead. Basically, we already did lot's of preliminary job in order to land VLA in CIR in llvm#367 llvm#346 llvm#340. So now we add initial VLA support itself. Most of the changes are taken from the original codegen, so there is nothing to be scary of) I added just one test, and basically that's all we can test right now. Later, I will add more, from the original codegen tests.